chideat / valkey-operator / 27890096313

24%

main: 22%

Pull #96

github

refactor(test): share FailoverInstance/ValkeyNode fakes; simplify size guard

Addresses code-review follow-ups (all test-only / no production behavior change):

- add internal/testutil with configurable FakeFailoverInstance and
  FakeValkeyNode, replacing three near-identical per-package mocks
  (failoverbuilder, ops/failover/actor, valkey/failover/monitor). The
  certmetav1.ObjectReference deprecation now surfaces once instead of 3x.
- simplify exceedsConfigMapSizeLimit to take a single dataSize (oldTotal and
  oldData always cancelled to 0 at the only call site); behavior unchanged.

Verified: ACL-rule validation is fully handled by pkg/types/user.Rule.Validate
(user webhook + pkg/security/acl), so the earlier dead-code removal left no gap.

Full unit suite incl. envtest is green.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

15 of 17 new or added lines in 11 files covered. (88.24%)

4844 of 20538 relevant lines covered (23.59%)

0.27 hits per line