astronomer / astro-cli
45%
main: 45%

LAST BUILD BRANCH: add-retries
DEFAULT BRANCH: main
Repo Added
Files 217
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH forward-process-env-to-compose
branch: forward-process-env-to-compose
CHANGE BRANCH
x

coverage: 45.091%. Remained the same
9754dc36-2798-478e-9835-21fe399566dd

Pull #2170

circleci

kaxil 
fix: Forward host environment to the compose loader so bare env passthrough resolves

astro dev start (Docker mode) builds its Compose project with
loader.LoadWithContext but left ConfigDetails.Environment unset. compose-go
resolves the bare host-env passthrough form (environment: [VAR] /
build.args: [VAR], with no value) by looking the variable name up in that
project Environment mapping (loader/environment.go resolveServicesEnvironment,
loader/normalize.go) -- a path separate from ${VAR} interpolation. With the
mapping empty, every bare passthrough silently resolved to nothing, diverging
from the plain docker compose CLI (which forwards the host environment) and from
astro's own standalone mode.

${VAR} interpolation was unaffected because it already used
Interpolate.LookupValue = os.LookupEnv.

Set Environment: composetypes.NewMapping(os.Environ()) on both ConfigDetails
literals (createDockerProject and createDockerProjectWithPorts) so bare
passthrough resolves to the host value, matching docker compose. A host
variable still reaches a container only when explicitly declared in the compose
YAML, so there is no new leakage surface.
Pull Request #2170: fix: Forward host environment to the compose loader so bare env passthrough resolves

1 of 2 new or added lines in 1 file covered. (50.0%)

25418 of 56370 relevant lines covered (45.09%)

7.81 hits per line

Relevant lines Covered
56370 RELEVANT LINES 25418 COVERED LINES
7.81 HITS PER LINE
Source Files on forward-process-env-to-compose

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
9754dc36... forward-process-env-to-compose fix: Forward host environment to the compose loader so bare env passthrough resolves astro dev start (Docker mode) builds its Compose project with loader.LoadWithContext but left ConfigDetails.Environment unset. compose-go resolves the bare host-... Pull #2170 kaxil circleci
45.09
0ae3710d... forward-process-env-to-compose fix: Forward host environment to the compose loader so bare env passthrough resolves astro dev start (Docker mode) builds its Compose project with loader.LoadWithContext but left ConfigDetails.Environment unset. compose-go resolves the bare host-... Pull #2170 kaxil circleci
44.78
See All Builds (695)