astronomer / astro-cli / 0ae3710d-3734-4378-8ccc-8bb9e46c456b

45%

main: 45%

Build Type

Pull #2170

circleci

Committed by kaxil

Commit Message

fix: Forward host environment to the compose loader so bare env passthrough resolves

astro dev start (Docker mode) builds its Compose project with
loader.LoadWithContext but left ConfigDetails.Environment unset. compose-go
resolves the bare host-env passthrough form (environment: [VAR] /
build.args: [VAR], with no value) by looking the variable name up in that
project Environment mapping (loader/environment.go resolveServicesEnvironment,
loader/normalize.go) -- a path separate from ${VAR} interpolation. With the
mapping empty, every bare passthrough silently resolved to nothing, diverging
from the plain docker compose CLI (which forwards the host environment) and from
astro's own standalone mode.

${VAR} interpolation was unaffected because it already used
Interpolate.LookupValue = os.LookupEnv.

Set Environment: composetypes.NewMapping(os.Environ()) on both ConfigDetails
literals (createDockerProject and createDockerProjectWithPorts) so bare
passthrough resolves to the host value, matching docker compose. A host
variable still reaches a container only when explicitly declared in the compose
YAML, so there is no new leakage surface.

Pull Request Pull Request #2170: fix: Forward host environment to the compose loader so bare env passthrough resolves

Coverage Stats

1 of 2 new or added lines in 1 file covered. (50.0%)

196 existing lines in 8 files now uncovered.

25031 of 55902 relevant lines covered (44.78%)

7.75 hits per line