astronomer / astro-cli

39%

main: 39%

LAST BUILD ON BRANCH dedup-client-headers

branch: dedup-client-headers

CHANGE BRANCH

x

Reset

• dedup-client-headers
• add-astro-api-registry-command
• add-client-registry-validation
• add-help-examples
• add-swagger2-and-custom-spec-url
• add-wait-time-flag
• add_polaris_cmd
• add_session_flag
• adds-plugin-system
• af2-to-af3-upgrade
• agent/ai-125
• agent/ai-84
• agent/build-839
• agent/local-1
• agent/local-2
• agent/local-5
• agent/local-6
• agent/local-7
• agent/local-8
• agent/pm-1178
• agent/pm-1197
• agent/pm-804
• ai
• api-command
• astro-deploy-improve-cmd-description
• astro-local-support
• backfill-force-flags
• bugfix/1909-handle-default-pool
• bugfix/1975-podman-runtime-warning
• claude/lucid-visvesvaraya
• dependabot/go_modules/github.com/getkin/kin-openapi-0.131.0
• dependabot/go_modules/github.com/go-git/go-git/v5-5.13.0
• dependabot/go_modules/golang.org/x/crypto-0.45.0
• dependabot/go_modules/golang.org/x/oauth2-0.27.0
• dependabot/pip/integration-test/requests-2.32.4
• dependabot/pip/integration-test/urllib3-2.6.0
• dependabot/pip/integration-test/urllib3-2.6.3
• deprecate_force-upgrade-to-af3
• feat/add-per-dp-software-registry-login
• feat/add_deployment_re_col
• feat/deploy-git-metadata
• feat/fix-dagserver-upload-url
• feat/fix-perdb-registry-login
• feat/nexus-integration
• feat/org-switch-workspace-id
• feat/portless-proxy
• feat/standalone-mode
• feat_config_cluster_id
• feature-1328
• feature/deploy-client-image
• feature/feature-flag-remote-command
• feature/migrate-codecov-to-coveralls
• feature/remote-deploy-cmd-runtime-version-validation
• fix-bind-mounts
• fix-remote-deploy
• fix-remote-deployment-status-text
• fix-telemetry-context
• fix-verbosity-issue
• fix/1721
• fix/1974
• fix/astro-agent-image-semver-selection
• fix/beautysh-setuptools
• fix/dev-init-remote-exec
• fix/dev-run-exit-code
• fix/mock-registry-tests
• fix/openapi-31-libopenapi
• fix/org-switch-pagination-fallback
• fix/osxcross-sdk-macos12
• fix/pytest-bind-mount-host-dirs
• fix/quick-fixes-batch-1
• fix/remote-deploy-dependency-install
• fix/standalone-pytest-pythonpath-include
• fix/standalone-strip-virtual-env
• fix/standalone-venv-allow-existing
• fix_ide_import
• fix_ide_import_cherry_pick
• fix_ide_project_url
• gh_7779
• houston-api-1.1.0-support
• ide_ignore_hidden_files
• improve-command-descriptions
• improve-remote-deploy-msg
• josh-fell/fix-pytest-theme-mock
• kaxilnaik/ai-77-pyprojecttoml-as-project-definition
• latest-release-1.36.0
• main
• neel-astro-patch-1
• neel-astro-patch-2
• neel-astro-patch-3
• nick3/deployment-copy-fixes
• nick3/update-version-checking
• nick3/upgrade-go
• pi-agent-prototype
• polaris-main
• pre-commit-ci-update-config
• pre-commit-lint
• prek
• release-1.36
• release-1.37
• release-1.38
• release-1.39
• release-1.40
• release-1.40.0
• release-1.41
• remote-dev-init
• remove-registry-commands
• revert-1956-feature/feature-flag-remote-command
• run-tests-never-touches-real-config
• schnie-patch-1
• software_to_apc
• standalone-open-browser
• standardize-error-messages
• stub-portless-windows
• telemetry
• update-codeowners
• update-godownloader-v1.40.0
• update-releaser-1.37
• update_ide_commands
• upgrade-test-fix-flag
• windows-tests

Build # 9cd4340e-2128-47d4-99a4-6878b2be5587

Build Type

Pull #2071

circleci

Committed by ashb

Commit Message

Move shared request editor and API error logic into pkg/httputil

Consolidates the duplicated TrueString constant, ErrorRequest/ErrorBaseURL/
HTTPStatus200/HTTPStatus204 vars, NormalizeAPIError function, and request
editor function from all three astro-client-*-core packages into a new
pkg/httputil/request_editor.go. Each client package now re-exports the
vars/const and delegates NormalizeAPIError to httputil, and constructs its
request editor via httputil.NewRequestEditorFn with its API path argument.

Also fixes the double x-astro-client-version header bug in
astro-client-core/client.go. The original code called Header.Add (which
appends, not overwrites) unconditionally after the switch that already set
it -- so every request carried two x-astro-client-version values. In the
deploy-action case the server would see both the deploy action version and
CurrVersion.

Pull Request Pull Request #2071: Move shared request editor and API error logic into pkg/httputil

Coverage Stats

11 of 57 new or added lines in 11 files covered. (19.3%)

3 existing lines in 1 file now uncovered.

24837 of 63137 relevant lines covered (39.34%)

9.51 hits per line