astronomer / astro-cli

40%

main: 45%

LAST BUILD ON BRANCH deadcode-tooling

branch: deadcode-tooling

CHANGE BRANCH

x

Reset

• deadcode-tooling
• Af2_restructure
• RNHTTR-patch-1
• add-astro-api-registry-command
• add-client-registry-validation
• add-help-examples
• add-swagger2-and-custom-spec-url
• add-wait-time-flag
• add_polaris_cmd
• add_session_flag
• adds-plugin-system
• af2-to-af3-upgrade
• af2_standalone
• agent/ai-125
• agent/ai-84
• agent/build-839
• agent/local-1
• agent/local-2
• agent/local-5
• agent/local-6
• agent/local-7
• agent/local-8
• agent/pm-1178
• agent/pm-1197
• agent/pm-804
• ai
• ai-475-c-from-file
• ai-475-link
• ai-485-otto-auto-download-latest
• api-command
• astro-deploy-improve-cmd-description
• astro-local-support
• backfill-force-flags
• bugfix/1909-handle-default-pool
• bugfix/1975-podman-runtime-warning
• chiomaonyekpere/plx-232-replace-updatedeploymentimage-with-upsertdeployment
• chore/appconfig-workspace-deployment-context
• chore/remove-houston-airflow-deprecations
• claude/lucid-visvesvaraya
• dedup-client-headers
• dependabot/go_modules/github.com/buger/jsonparser-1.1.2
• dependabot/go_modules/github.com/getkin/kin-openapi-0.131.0
• dependabot/go_modules/github.com/go-git/go-billy/v5-5.9.0
• dependabot/go_modules/github.com/go-git/go-git/v5-5.13.0
• dependabot/go_modules/github.com/go-git/go-git/v5-5.19.0
• dependabot/go_modules/github.com/go-git/go-git/v5-5.19.1
• dependabot/go_modules/github.com/in-toto/in-toto-golang-0.11.0
• dependabot/go_modules/github.com/moby/spdystream-0.5.1
• dependabot/go_modules/go.opentelemetry.io/otel/exporters/otlp/otlpmetric/otlpmetrichttp-1.43.0
• dependabot/go_modules/go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracehttp-1.43.0
• dependabot/go_modules/go.opentelemetry.io/otel/sdk-1.43.0
• dependabot/go_modules/golang.org/x/crypto-0.45.0
• dependabot/go_modules/golang.org/x/oauth2-0.27.0
• dependabot/pip/integration-test/idna-3.15
• dependabot/pip/integration-test/pytest-9.0.3
• dependabot/pip/integration-test/requests-2.32.4
• dependabot/pip/integration-test/requests-2.33.0
• dependabot/pip/integration-test/urllib3-2.6.0
• dependabot/pip/integration-test/urllib3-2.6.3
• dependabot/pip/integration-test/urllib3-2.7.0
• deprecate_force-upgrade-to-af3
• deps-docker-stack-bump
• drop-af-config-devnull
• enhance_cli_release_process
• enhance_telemetry
• feat/add-per-dp-software-registry-login
• feat/add_deployment_re_col
• feat/deploy-git-metadata
• feat/fix-apc-token-login-flow
• feat/fix-dagserver-upload-url
• feat/fix-perdb-registry-login
• feat/nexus-integration
• feat/org-switch-workspace-id
• feat/portless-proxy
• feat/standalone-mode
• feat_config_cluster_id
• feature-1328
• feature/deploy-client-image
• feature/feature-flag-remote-command
• feature/migrate-codecov-to-coveralls
• feature/remote-deploy-cmd-runtime-version-validation
• fix-bind-mounts
• fix-remote-custom-deploy
• fix-remote-deploy
• fix-remote-deployment-status-text
• fix-standalone-pythonpath
• fix-telemetry-context
• fix-verbosity-issue
• fix/1721
• fix/1974
• fix/astro-agent-image-semver-selection
• fix/beautysh-setuptools
• fix/dev-init-remote-exec
• fix/dev-run-exit-code
• fix/mock-registry-tests
• fix/no-fail-image-name
• fix/openapi-31-libopenapi
• fix/org-switch-pagination-fallback
• fix/osxcross-sdk-macos12
• fix/otto-unsupported-platform
• fix/pytest-bind-mount-host-dirs
• fix/quick-fixes-batch-1
• fix/release-workflow-tag-filter
• fix/remote-deploy-dependency-install
• fix/remote-exec-image-name-deploy
• fix/standalone-pytest-pythonpath-include
• fix/standalone-strip-virtual-env
• fix/standalone-venv-allow-existing
• fix_ide_import
• fix_ide_import_cherry_pick
• fix_ide_project_url
• fix_podman_windows
• gh_7779
• gitignore-astro-local-yml
• gn/checkhealth-context
• houston-api-1.1.0-support
• ide_ignore_hidden_files
• ignore_yanked
• improve-command-descriptions
• improve-remote-deploy-msg
• jakeferriero/afe-76-pinning-dependencies-temporarily
• josh-fell/fix-pytest-theme-mock
• julian/astro-agent
• julian/bump-af-pin-0.6.4
• julianlaneve/ai-432-astro-deploy-image-name-should-not-require-an-astro-51c2
• julianlaneve/ai-446-fix-incorrect-airflow-ui-url-printed-on-windows-8f12
• julianlaneve/ai-464-image-name-implies-image-only-regression
• julianlaneve/build-975-cli-logs-log-count-shows-too-few-logs-bf5e
• julianlaneve/check-env-bool-numeric
• julianlaneve/deployment-logs-component-flag
• julianlaneve/pin-github-actions
• julianlaneve/standalone-af2-basic-auth
• kaxilnaik/ai-77-pyprojecttoml-as-project-definition
• latest-release-1.36.0
• main
• neel-astro-patch-1
• neel-astro-patch-2
• neel-astro-patch-3
• nick3/deployment-copy-fixes
• nick3/update-version-checking
• nick3/upgrade-go
• otto-alias-upgrade
• otto-autoupdate-version-pin
• otto-respect-telemetry-config
• otto/tab-completion
• pi-agent-prototype
• plx-324-could-not-deploy-dags-in-dod-deployment
• polaris-main
• pre-commit-ci-update-config
• pre-commit-lint
• prek
• proxy-project-name
• release-1.36
• release-1.37
• release-1.38
• release-1.39
• release-1.40
• release-1.40.0
• release-1.41
• release-1.42
• remote-dev-init
• remove-registry-commands
• remove-v1beta1
• revert-1956-feature/feature-flag-remote-command
• run-tests-never-touches-real-config
• sa/fix-organization-switch
• schnie-patch-1
• software_to_apc
• stale-issues-workflow
• standalone-open-browser
• standardize-error-messages
• store-creds-in-secure-os-backed-store
• stub-portless-windows
• support-local-spec-files
• tayloramurphy/otto-unauth-trial
• telemetry
• update-codeowners
• update-godownloader-1.41.0
• update-godownloader-1.42.0
• update-godownloader-v1.40.0
• update-releaser-1.37
• update_ide_commands
• upgrade-golangci-lint
• upgrade-test-fix-flag
• win_os_proxy
• windows-tests
• worktree-ai-475-astro-env
• worktree-batch-import-settings

Build # bc070376-7aaa-4f45-b2c6-71805ef2c2f3

Build Type

Pull #2127

circleci

Committed by schnie

Commit Message

chore(ci): add deadcode tooling

Add a whole-program dead-function check using
`golang.org/x/tools/cmd/deadcode` to catch exported orphan funcs that
`golangci-lint`'s in-package `unused` analyzer cannot. This is the
analogue of astro-desktop's setup.

How it's wired:
- `scripts/check-deadcode.sh` runs `deadcode -test` and fails on any
  finding within the cli's binary-style directories (`cmd/`, `airflow/`,
  `cloud/`, `software/`, `config/`, `settings/`, `houston/`, etc.).
  Library sub-modules (`pkg/airflowrt`, `pkg/proxy`, `pkg/astroauth`,
  `pkg/telemetry`, `astro-client-platform-core`) and the rest of `pkg/`
  are excluded because they are consumed by external Go modules
  (e.g. astro-desktop) — reachability from `cmd/astro/main` is not a
  correctness signal for them.
- `prek.toml` gains a `deadcode` hook that pins
  `golang.org/x/tools/cmd/deadcode@v0.27.0` and runs the script.
- `make lint` now runs `make lint-go` (golangci-lint) +
  `make lint-deadcode` (the new hook). CircleCI's `lint` job runs both
  as separate steps for clearer logs.
- `CONTRIBUTING.md` documents the layers and scope.

Baseline is zero — the previous commit cleaned up the four pre-existing
dead test funcs the tool surfaced.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Pull Request Pull Request #2127: chore(ci): add deadcode tooling to catch exported orphan funcs

Coverage Stats

26254 of 65891 relevant lines covered (39.84%)

9.4 hits per line