astronomer / astro-cli / c1c4f79c-8fb9-4485-afea-f88585b6d50e

39%

main: 39%

Build Type

Pull #2071

circleci

Committed by ashb

Commit Message

Move shared request editor and API error logic into pkg/httputil

Consolidates the duplicated TrueString constant, ErrorRequest/ErrorBaseURL/
HTTPStatus200/HTTPStatus204 vars, NormalizeAPIError function, and request
editor function from all three astro-client-*-core packages into a new
pkg/httputil/request_editor.go. Each client package now re-exports the
vars/const and delegates NormalizeAPIError to httputil, and constructs its
request editor via httputil.NewRequestEditorFn with its API path argument.

Also fixes the double x-astro-client-version header bug in
astro-client-core/client.go. The original code called Header.Add (which
appends, not overwrites) unconditionally after the switch that already set
it -- so every request carried two x-astro-client-version values. In the
deploy-action case the server would see both the deploy action version and
CurrVersion.

Pull Request Pull Request #2071: Move shared request editor and API error logic into pkg/httputil

Coverage Stats

11 of 57 new or added lines in 11 files covered. (19.3%)

40 existing lines in 3 files now uncovered.

24839 of 63138 relevant lines covered (39.34%)

9.51 hits per line