antchfx / xpath

85%

master: 84%

LAST BUILD ON BRANCH rune-correct-string-functions

branch: rune-correct-string-functions

CHANGE BRANCH

x

Reset

• rune-correct-string-functions
• 0.1
• 1.1.0
• fix-ancestor-predicate-chain
• fix-group-predicate-last
• fix-round-mod-numeric-spec
• fix/clone-nil-input
• fix/nil-input-clone
• master
• matches-empty-nodeset
• refs/tags/v1.3.0
• refs/tags/v1.3.1
• refs/tags/v1.3.2
• refs/tags/v1.3.3
• refs/tags/v1.3.4
• refs/tags/v1.3.5
• refs/tags/v1.3.6
• refs/tags/v1.3.7
• refs/tags/v1.3.8
• v1.0.0
• v1.1.0
• v1.1.1
• v1.1.10
• v1.1.11
• v1.1.2
• v1.1.3
• v1.1.4
• v1.1.5
• v1.1.6
• v1.1.7
• v1.1.8
• v1.1.9
• v1.2.0

Build # 34819574471

Build Type

Pull #139

github

Committed by youdie006

Commit Message

Make string-length, substring and translate count characters

XPath 1.0 4.2 defines these in characters; all three index by byte, so
string-length("日本語") is 9 and substring("日本語abc", 2, 2) returns a
byte slice that is not valid UTF-8. stringLengthFunc's own doc comment
already says "number of characters".

The three move together: fixing string-length alone turns the common
idiom substring(s, 1, string-length(s)) from "hello" into a truncated
string, because the length is then in characters but the slice is in
bytes.

normalizespaceFunc already converts to []rune for the same reason.

Pull Request Pull Request #139: Make string-length, substring and translate count characters

Coverage Stats

13 of 13 new or added lines in 1 file covered. (100.0%)

2526 of 2985 relevant lines covered (84.62%)

336.04 hits per line