antchfx / xpath
78%
master: 78%

LAST BUILD BRANCH: fix-ancestor-predicate-chain
DEFAULT BRANCH: master
Repo Added
Files 8
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH fix-ancestor-predicate-chain
branch: fix-ancestor-predicate-chain
CHANGE BRANCH
x

coverage: 78.01% (+0.03%) from 77.98%
19214782526

Pull #119

github

mislav 
Fix chained predicates on ancestor axis

The XPath expression with chained predicates on the ancestor axis was not
working correctly. For example:
  //*[@itemprop="author"][ancestor::*[@itemscope][1][@itemtype="Comment"]]

This expression should find all elements with @itemprop="author" whose first
@itemscope ancestor has @itemtype="Comment". However, it was returning 0
results instead of the expected elements.

Root cause:
1. ancestorQuery.table (deduplication table) was persisting across Evaluate()
   calls, preventing ancestors from being found for subsequent input contexts.
2. filterQuery.positmap (position map) was not being reset during Evaluate(),
   causing position tracking to be incorrect when the same predicate query was
   reused for multiple input nodes.

Fix:
- Reset ancestorQuery.table to nil in Evaluate() to ensure clean state for
  each evaluation
- Reset filterQuery.positmap to nil in Evaluate() to ensure clean state for
  each evaluation

These changes ensure that when a predicate query is evaluated multiple times
(once for each candidate node), the internal state is properly reset, allowing
the query to work correctly for each evaluation.

💁 Unit test by Mislav
🤖 Implementation by [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
Pull Request #119: Fix chained predicates on ancestor axis

4 of 4 new or added lines in 1 file covered. (100.0%)

2313 of 2965 relevant lines covered (78.01%)

232.11 hits per line

Relevant lines Covered
2965 RELEVANT LINES 2313 COVERED LINES
232.11 HITS PER LINE
Source Files on fix-ancestor-predicate-chain

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
19214782526 fix-ancestor-predicate-chain Fix chained predicates on ancestor axis The XPath expression with chained predicates on the ancestor axis was not working correctly. For example: //*[@itemprop="author"][ancestor::*[@itemscope][1][@itemtype="Comment"]] This expression should f... Pull #119 mislav github
78.01
See All Builds (153)