antchfx / xpath

80%

master: 82%

LAST BUILD ON BRANCH fix-round-mod-numeric-spec

branch: fix-round-mod-numeric-spec

CHANGE BRANCH

x

Reset

• fix-round-mod-numeric-spec
• 0.1
• 1.1.0
• fix-ancestor-predicate-chain
• fix-group-predicate-last
• master
• refs/tags/v1.3.0
• refs/tags/v1.3.1
• refs/tags/v1.3.2
• refs/tags/v1.3.3
• refs/tags/v1.3.4
• refs/tags/v1.3.5
• refs/tags/v1.3.6
• refs/tags/v1.3.7
• refs/tags/v1.3.8
• v1.0.0
• v1.1.0
• v1.1.1
• v1.1.10
• v1.1.11
• v1.1.2
• v1.1.3
• v1.1.4
• v1.1.5
• v1.1.6
• v1.1.7
• v1.1.8
• v1.1.9
• v1.2.0

Build # 29692471652

Build Type

Pull #128

github

Committed by gaoflow

Commit Message

fix: round() and mod follow the XPath 1.0 numeric spec

round() rounded halves away from zero and dropped the non-finite cases via the
int cast (REC 4.4); it now returns a number like ceiling()/floor(), so halves
round toward +Infinity and NaN/+-Infinity pass through. Since it no longer needs
the go1.10-only math.Round it moves next to roundFunc.

mod truncated its operands to int and panicked on a zero divisor; math.Mod is
the truncating remainder the spec requires (REC 3.5), with NaN for mod by zero.

Pull Request Pull Request #128: fix: round() and mod follow the XPath 1.0 numeric spec

Coverage Stats

14 of 14 new or added lines in 2 files covered. (100.0%)

2395 of 2976 relevant lines covered (80.48%)

271.72 hits per line