antchfx / xpath / 34819574471

85%

master: 85%

Pull #139

github

Make string-length, substring and translate count characters

XPath 1.0 4.2 defines these in characters; all three index by byte, so
string-length("日本語") is 9 and substring("日本語abc", 2, 2) returns a
byte slice that is not valid UTF-8. stringLengthFunc's own doc comment
already says "number of characters".

The three move together: fixing string-length alone turns the common
idiom substring(s, 1, string-length(s)) from "hello" into a truncated
string, because the length is then in characters but the slice is in
bytes.

normalizespaceFunc already converts to []rune for the same reason.

13 of 13 new or added lines in 1 file covered. (100.0%)

2526 of 2985 relevant lines covered (84.62%)

336.04 hits per line