LoLab-VU / pysb

74%

master: 79%

LAST BUILD ON BRANCH export_compartments

branch: export_compartments

CHANGE BRANCH

x

Reset

• export_compartments
• JamesPino-patch-1
• add_python2_to_travis
• alias_components
• appveyorfix
• asv
• benchmarking
• bidirectional_fix
• bngSSASimulator
• bng_read_expr_from_gdat
• bng_simulator
• bngconsole
• bngl_import
• boole2rules
• celery
• cupsoda
• cupsoda_logging
• cupsoda_py3
• cupsoda_simulator
• cytoscapejs
• dae
• dev
• dev_may2017
• drug_binding_macro
• duplicate_sites
• dupsites_localfxns
• ems_monintegrator
• fast_exprs
• fast_netfiles
• fix_solver_verbose
• gpu_ssa
• hybrid_particle_population
• influence_nets
• is_equivalent_to
• kappatests
• kasimPy3errorfix
• lassie
• lcs
• master
• more_docs
• multi
• new_revrule_op
• nfsim
• pysbflat_matchonce
• remove_pygraphiv_add_dot
• remove_pygraphviz_dep_render_network
• rule_function
• sensitivity_analysis
• simclass_LAH
• simcls_stochkit
• simres_hdf5
• simulatorclass
• sphinxfix
• sphinxver
• stochkit
• synth_without_initials
• test2-rebase-cupsoda
• update_sensitivity_tool
• v1.6.0
• v1.7.0
• v1.9.0
• v1.9.1

Build # 540

Build Type

push

travis-ci

Committed by alubbock

Commit Message

Fix `is_equivalent_to` for compartmental models

Currently, the `is_equivalent_to` method does not consider species
with a defined Monomer compartment, species compartment or both to
be equivalent, i.e. the following are all different:

 * A() ** C1 # monomer compartment
 * ComplexPattern([A()], compartment=C1) # species compartment
 * ComplexPattern([A() ** C1, compartment=C1) # species and monomer
                                              # compartments

These should all be equivalent, which is fixed in this patch.

I've also added a check in the `is_equivalent_to` method to check
that the ComplexPatterns are concrete, i.e. species, and not
abstract patterns, as the matching rules are subtly different.

Resolves: pysb/pysb#257

Run Details

5177 of 7004 relevant lines covered (73.91%)

1.31 hits per line