Instagram / IGListKit

96%

master: 100%

LAST BUILD ON BRANCH main

branch: main

CHANGE BRANCH

x

Reset

• main
• 2.0.0
• 2.1.0
• 3.0.0
• 3.1.0
• 3.1.1
• add-checklist
• animated-update
• auto-diff
• auto-diff1
• automation-travis
• background-diff
• bad-update
• base-test
• binding-guide
• build-on-device
• category-linking
• center
• changelog
• changelog-fixes
• changelog-fixup
• changelog-tbd
• chore/dangerfile_noise
• cleanup-layout
• collection-view-layout-precision
• collectionview-reuse
• compiler
• config
• coverall
• danger-init
• debug-dump
• defer-invalidate
• dep-demo
• deprecate-pods
• deselect
• disable-9_3-tests
• display-delegate
• display-suppl
• docs
• docs-patch
• docs-update
• documentation-updates
• double-inserts
• double-reload
• embed-crash
• equal-guide
• equality-guide-update
• faq
• fix-build
• fix-danger
• fix-examples
• fix-github-ci
• fix-headers
• fix-iglistbindingsectioncontroller-generics
• fix-links
• fix-readme-links
• fix-tv
• fix_layout_invalidation_659
• gen-docs
• guide-cleanup
• guides-setup
• index-for-cell-nil
• initial-faq-guide
• instagram-clone-demo-app
• ios11-examples
• ios11-pod-warnings
• ipad-ci-update
• jessesquires-patch-1
• jessesquires-patch-2
• layout
• layout-2
• layout-fit
• less-layout
• lolwut-dafuck
• master
• migration-3
• migration-format
• move-items
• move-section-index-to-property
• move-uicv-out-of-list-adapter
• moves-deleted
• multiple-delete
• negative-sizes
• newline
• nit-tests
• objc-fixup
• optional-crash
• organize
• path-description
• project-fixups
• protocol-gone-readme
• protocolize-list-view
• rawlinxx-master
• readme-refine
• readme-tweaks
• readme_starter_tasks
• refine-changelog
• regen-docs
• relax_swiftlint
• release-2.1.0
• release-2.x
• release-4.0-tableview-support
• reload-bug
• reload-tests
• remove-lint
• retain-cycle
• scroll-bottom-inset
• section-index-reset-on-adapter-dealloc
• simpler-travis
• slather-exclude
• stable
• stack-demo
• stack-offset
• stacked-working
• supplementary-example
• swift4
• test-coverage
• test-cycle
• tests
• travis
• travis-omfg
• travis-patch
• travis-update
• tvOS-support
• tvos-tests
• ui-tests
• uicv-dump
• unbreak
• unused
• update-changelog
• update-crash
• update-issue-template
• update-travis
• update-versions
• updater-tests
• vision
• weak-uicv

Build # 20127244776

Build Type

push

github

Committed by meta-codesync[bot]

Commit Message

Enable unit test suite for tvOS (#1649)

Summary:
## Changes in this pull request

Following up on https://github.com/instagram/IGListKit/issues/1401! This PR pulls in koenpunt's PR for tvOS test support and updates it against the latest version of IGListKit.

A few changes:

* I disabled the unit tests that require storyboards/NIBs for tvOS since we only have iOS formatted assets. We can follow this up in a future PR if need be.
* Rewrote the Travis build command for GitHub Actions
* Went through and gated any UIKit APIs that aren't available on tvOS.
* A few unit tests were failing since UICollectionView on tvOS does have a few implicit behavioral differences. I gated these for now, but if anyone using IGListKit on tvOS actually encounters these errors, please open an issue so we can track it and adjust our test suite accordingly.

### Checklist

- [x] All tests pass. Demo project builds and runs.
- [x] I added tests, an experiment, or detailed why my change isn't tested.
- [x] I added an entry to the `CHANGELOG.md` for any breaking changes, enhancements, or bug fixes.
- [x] I have reviewed the [contributing guide](https://github.com/Instagram/IGListKit/blob/main/.github/CONTRIBUTING.md)

Pull Request resolved: https://github.com/instagram/IGListKit/pull/1649

Reviewed By: jurmarcus

Differential Revision: D88921781

Pulled By: TimOliver

fbshipit-source-id: fb8b0becd

Run Details

4345 of 4531 relevant lines covered (95.89%)

696.82 hits per line