Instagram / IGListKit / 25713764463
99%
master: 100%

LAST BUILD BRANCH: main
DEFAULT BRANCH: master
Ran
Jobs 1
Files 54
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 98.816%. Remained the same
25713764463

push

github

meta-codesync[bot] 
De-genericize IGListBindingSectionController for Swift migration

Summary:
## Plan
This module doesn't need A/B testing and will be migrated directly.

## This Diff
Removes the `__covariant ObjectType : id<IGListDiffable>` lightweight generic type parameter from `IGListBindingSectionController`. Swift generic types cannot be exposed to ObjC, so any generic ObjC class must lose its type parameter when converted to Swift. This degenerification is a required prerequisite for future Swift migration.

Changes:
- Removed the generic type parameter from the class header, replacing `ObjectType` with `id<IGListDiffable>` in the `object` property declaration
- Removed the generic specialization from the `IGContentAppreciationGiftSectionController` subclass header
- Simplified 87 Swift files that referenced `ListBindingSectionController<ListDiffable>` or `ListBindingSectionController<any ListDiffable>` or other specializations to plain `ListBindingSectionController`
- Added ObjC casts at 3 callsites where the `.object` property was used with specialized type access (`IGAudioSearchResultsViewController.mm`, `IGDSShowcaseListExampleModel.m`)
- Added Swift casts at callsites in `BCNComposerPostSectionController`, `BCNComposerViewController`, `BCNPostingStatusDatasource`, `BCNComposerAssetSectionController`, and `GiftsFeedSectionController` where `.object` was accessed as the previously-specialized type

Differential Revision: D104311510

fbshipit-source-id: 6f54a761a

4508 of 4562 relevant lines covered (98.82%)

703.73 hits per line

Jobs
ID Job ID Ran Files Coverage
1 iOS - 25713764463.1 59
98.69
 GitHub Action Run
Source Files on build 25713764463