Instagram / IGListKit / 24539907142

99%

master: 100%

Build Type

push

github

Committed by meta-codesync[bot]

Commit Message

Replace IGFailAssert with NSLog for delegate recursion checks

Summary:
The delegate recursion protection code (for GitHub issue #1658) uses IGFailAssert to warn about invalid delegate configurations. However, IGFailAssert is defined as NSCAssert which throws exceptions in debug/test builds, preventing the recovery code from executing.

This change replaces IGFailAssert with NSLog for these 4 specific cases
where the code is designed to gracefully recover:

1. When setting collectionView and _scrollViewDelegate points to it
2. When setting collectionView and _collectionViewDelegate points to it
3. When calling setCollectionViewDelegate: with the collectionView itself
4. When calling setScrollViewDelegate: with the collectionView itself

By using NSLog instead, the warning is still logged but execution continues, allowing the recovery code (clearing delegates or returning early) to run.
This fixes 23 test failures in IGListKitTests where tests were either:
- Intentionally testing the delegate protection behavior
- Inadvertently triggering the assertion when swapping adapters/collection views

Differential Revision: D101185192

fbshipit-source-id: 1f7cdc70b

Coverage Stats

8 of 8 new or added lines in 1 file covered. (100.0%)

10 existing lines in 1 file now uncovered.

4506 of 4560 relevant lines covered (98.82%)

703.97 hits per line