Eyevinn / mp4ff
83%
master: 83%

LAST BUILD BRANCH: fix/segmenter-last-sample
DEFAULT BRANCH: master
Repo Added
Files 221
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH perf/encrypt-allocs
branch: perf/encrypt-allocs
CHANGE BRANCH
x

coverage: 82.588% (+0.02%) from 82.565%
37010599950

Pull #616

github

tobbee 
perf(mp4): encrypt fragments without per-sample allocations in cbcs

FragmentEncryptor.EncryptFragment allocated for every sample: a slice of subsample patterns, a new CBC encrypter for every subsample in cbcs, a new IV slice for every sample in cenc, and a parsed avc.SliceHeader for every cbcs slice.

Now the encryptor creates one CBC encrypter and resets it with SetIV at the start of every protected range, which the encrypters of the standard library support, including the FIPS 140 AES one that Go 1.24 and later return; another cipher.Block falls back to the previous code. The per-sample IVs and subsample patterns, which senc and saiz keep until the fragment is encoded, get one array each per fragment, and every sample's entry is capped with a full slice expression so that later appends cannot overwrite it. The IV is advanced in scratch arrays in the encryptor, the full samples are collected with AppendFullSamples into a reused slice, and cbcs AVC ranges use avc.SliceHeaderSize. The unexported sampleProtector interface appends ranges to a slice, and HEVC and AV1 append the result of their existing functions.

FragmentEncryptor.IV now returns a copy. It returned the encryptor's own slice, so a caller that changed the returned IV changed the IV of the next fragment, and since the IV is now updated in place, a returned IV would also have changed after the next fragment.

The output is byte-for-byte the same as before for AVC, HEVC, AV1 and AAC, with cenc and 8- and 16-byte IVs and with cbcs, for the test segments as they are and as one-sample fragments, both with one FragmentEncryptor and with chained EncryptFragment calls (36 outputs, compared with a throwaway test).

BenchmarkEncryptFragments (testdata/1.m4s, Apple M4 Pro, n=8):
- cbcs, one 60-sample fragment: 22.3 µs -> 18.0 µs, 190 -> 12 allocations
- cbcs, 60 one-sample fragments: 27.7 µs -> 23.8 µs, 603 -> 425 allocations
- cenc, one 60-sample fragment: 10.5 µs -> 10.0 µs, 192 -> 73 allocations
-... (continued)
Pull Request #616: perf(mp4): encrypt fragments without per-sample allocations in cbcs

80 of 85 new or added lines in 1 file covered. (94.12%)

23104 of 27975 relevant lines covered (82.59%)

0.83 hits per line

Relevant lines Covered
27975 RELEVANT LINES 23104 COVERED LINES
0.83 HITS PER LINE
Source Files on perf/encrypt-allocs

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
37010599950 perf/encrypt-allocs perf(mp4): encrypt fragments without per-sample allocations in cbcs FragmentEncryptor.EncryptFragment allocated for every sample: a slice of subsample patterns, a new CBC encrypter for every subsample in cbcs, a new IV slice for every sample in c... Pull #616 tobbee github
82.59
37008910290 perf/encrypt-allocs perf(mp4): encrypt fragments without per-sample allocations in cbcs FragmentEncryptor.EncryptFragment allocated for every sample: a slice of subsample patterns, a new CBC encrypter for every subsample in cbcs, a new IV slice for every sample in c... Pull #616 tobbee github
82.59
37008873014 perf/encrypt-allocs perf(mp4): encrypt fragments without per-sample allocations in cbcs FragmentEncryptor.EncryptFragment allocated for every sample: a slice of subsample patterns, a new CBC encrypter for every subsample in cbcs, a new IV slice for every sample in c... Pull #616 tobbee github
82.59
See All Builds (624)