Eyevinn / mp4ff

83%

master: 83%

LAST BUILD ON BRANCH improve-av1

branch: improve-av1

CHANGE BRANCH

x

Reset

• improve-av1
• av1-crypto-rap
• av1-update
• avs3
• chore-bump-min-go-1.18
• chore-bump-min-go-1.19
• chore/prepare-v0.53.0
• codespell
• colr-icc-decode
• dac4
• decode-box-body-sr
• feat-coll-box
• feat-hevc-encrypt
• feat-ivf
• feat-lbli-sample-group
• feat-lhvc-box
• feat-linf-oinf-sample-groups
• feat-mvhevc-builders
• feat-mvhevc-cli
• feat-trgr-track-group
• feat-vexu-spatial-video
• feat-vp-codec-sample-box
• feat-vps-multilayer-extension
• feat/dolby-vision-dvh1-dvhe
• feat/hevc-hdr-boxes
• feat/mov-decoder
• feat/piff
• feat/stream-read-mdat-data
• feature-encryption-boxes
• feature/exporttfhd
• fix-avcdecoderconfig
• fix-co64-size-overflow
• fix-goreleaser-brew
• fix-hevc-ps-dos
• fix-interleaved-sidx-boxes
• fix-mime-box
• fix-senc-panic
• fix-senc-robustness
• fix-short-esds-issue-393
• fix-sliceheader-spsid
• fix-ssix-box
• fix-stsc
• fix-subs-box
• fix-trailing-avc1-bytes
• fix-typos
• fix-vps-ols0-necessary-layers
• fix/cenc-encrypt-conformance
• fix/cenc-increment
• flac
• fuzz-box
• go-releaser
• golangci-lint-v2
• handle-trailing-avc1-bytes
• hevc-vps
• iMro0t-feature-encryption-boxes
• iMro0t-fix-avcdecoderconfig
• improved-crypt-tools
• issue-492
• master
• mdhd-dur-info
• minimal-ac4
• more-robust-decode
• mp4-blackbox-test
• mpeg-h
• new-pssh-func
• opus
• patch-1
• release/v0.51.0
• release/v0.52.0
• remove-homebrew-cask
• return-partial-files
• sampleflags-test
• sei-recovery-point
• spherical-v1-no-xml
• sphericalv1
• stream-process
• test-header-parsing
• test-visualsampleentry
• update-changelog
• update-coverage-job
• update-docs
• update-make
• v0.48.0
• v0.49.0
• v0.50.0
• vtpl1-master
• vvc
• vvc-nal-headers
• weird-dac3

Build # 28998478488

Build Type

Pull #525

github

Committed by tobbee

Commit Message

refactor(crypto): immutable InitProtectData with per-sequence FragmentEncryptor

The AV1 protection-range function captures a mutable frame-header decoder whose
reference-frame state accumulates across samples in decode order. Storing it in the
long-lived, apparently-shareable InitProtectData (as ProtFunc did) made it unsafe to
reuse across segments or share between concurrent encryptions.

Split immutable config from per-run state: InitProtectData now holds an unexported
sampleProtector factory (no ProtFunc field, ProtectionRangeFunc removed) and is safe to
share. A new FragmentEncryptor (InitProtectData.NewFragmentEncryptor) owns the mutable,
decode-order state, and EncryptFragments encrypts a whole decode sequence with one fresh
protector - the correct entry point for multi-fragment AV1 segments. EncryptFragment
remains for a single self-contained fragment.

HEVC parameter sets are now parsed once per run instead of per sample. mp4ff-encrypt uses
one FragmentEncryptor per media segment. Adds a concurrency test that shares one
InitProtectData across goroutines encrypting AV1 (race-free, identical output).

Pull Request Pull Request #525: refactor(crypto): immutable InitProtectData with per-sequence FragmentEncryptor

Coverage Stats

67 of 98 new or added lines in 2 files covered. (68.37%)

3 existing lines in 2 files now uncovered.

23153 of 27981 relevant lines covered (82.75%)

0.92 hits per line