Eyevinn / mp4ff
83%
master: 83%

LAST BUILD BRANCH: fix/extract-protect-avc3-hev1
DEFAULT BRANCH: master
Repo Added
Files 221
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH perf/ebsp-allocs
branch: perf/ebsp-allocs
CHANGE BRANCH
x

coverage: 82.565% (+0.03%) from 82.533%
37002615480

Pull #614

github

tobbee 
perf(bits,avc): read EBSP without allocating per byte

EBSPReader.Read fetched every byte with binary.Read, which allocates since the byte escapes through an interface: 13 allocations to parse an AVC slice header and 28 for an SPS. Read now uses ReadByte when the reader is an io.ByteReader, as the bytes.Reader and bytes.Buffer of all AVC and HEVC parameter set and slice header parsers are, and io.ReadFull into a local array otherwise.

NewEBSPReaderFromSlice reads directly from a slice and goes back in it for MoreRbspData without seeking. ParseSliceHeader uses it, and the new avc.SliceHeaderSize returns only the header size without allocating a SliceHeader, which is all that cbcs subsample encryption needs.

BenchmarkParseNALUnits (Apple M4 Pro, n=10):
- ParseSliceHeader: 341 ns -> 263 ns, 13 -> 1 allocations
- ParseSPSNALUnit: 568 ns -> 359 ns, 28 -> 3 allocations
- SliceHeaderSize: 244 ns, 0 allocations

TestEBSPReaderKinds runs the same reads, Exp-Golomb codes, MoreRbspData and trailing bits, across emulation prevention bytes and the end of data, through a slice, an io.ReadSeeker and a plain io.Reader, and requires identical values, positions and errors. TestEBSPReaderAllocations fails on master with 101 allocations for 100 bytes. TestSliceHeaderSize checks that SliceHeaderSize returns ParseSliceHeader's size and error for the test streams and for truncated, weighted-prediction and unknown-PPS slices.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Pull Request #614: perf(bits,avc): read EBSP without allocating per byte

44 of 48 new or added lines in 2 files covered. (91.67%)

23058 of 27927 relevant lines covered (82.57%)

0.83 hits per line

Relevant lines Covered
27927 RELEVANT LINES 23058 COVERED LINES
0.83 HITS PER LINE
Source Files on perf/ebsp-allocs

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
37002615480 perf/ebsp-allocs perf(bits,avc): read EBSP without allocating per byte EBSPReader.Read fetched every byte with binary.Read, which allocates since the byte escapes through an interface: 13 allocations to parse an AVC slice header and 28 for an SPS. Read now uses R... Pull #614 tobbee github
82.57
See All Builds (638)