Eyevinn / mp4ff
83%
master: 83%

LAST BUILD BRANCH: fix/extract-protect-avc3-hev1
DEFAULT BRANCH: master
Repo Added
Files 221
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH fix/external-data-references
branch: fix/external-data-references
CHANGE BRANCH
x

coverage: 82.603% (+0.004%) from 82.599%
37015048333

Pull #618

github

tobbee 
fix(mp4): reject sample data stored in other files

A track's sample entries point through data_reference_index to dref entries. A url entry without the self-contained flag puts the data in another file, as in Unified Streaming dref MP4s (mp4split --use_dref, Remix output) and MP4Box -dref files. mp4ff ignored this and read the chunk offsets from the file's own mdat. Without an mdat, mp4ff-crop and the segmenter example panicked. With one, in a file mixing referenced and self-contained tracks, mp4ff-crop wrote the wrong bytes and kept the reference.

Add TrakBox.CheckDataIsSelfContained and call it from File.CopySampleData and from the tools that read progressive sample data. The check reads the self-contained flag from any data entry, since QuickTime alis entries set it too. A url entry without a location, a missing dref, or an index outside it count as self-contained, so files that worked before still do. MdatBox.ReadData and CopyData now return an error for a nil mdat.

prog_8s_dref.mp4 is made with MP4Box -dref -add prog_8s.mp4 and refers to prog_8s.mp4 in the same directory. alis is added to the codespell ignore list as a QuickTime data entry type.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Pull Request #618: fix(mp4): reject sample data stored in other files

58 of 71 new or added lines in 10 files covered. (81.69%)

23181 of 28063 relevant lines covered (82.6%)

0.83 hits per line

Relevant lines Covered
28063 RELEVANT LINES 23181 COVERED LINES
0.83 HITS PER LINE
Source Files on fix/external-data-references

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
37015048333 fix/external-data-references fix(mp4): reject sample data stored in other files A track's sample entries point through data_reference_index to dref entries. A url entry without the self-contained flag puts the data in another file, as in Unified Streaming dref MP4s (mp4split... Pull #618 tobbee github
82.6
See All Builds (638)