• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

Eyevinn / mp4ff
84%
master: 85%

Build:
Build:
LAST BUILD BRANCH: fix/crop-tables
DEFAULT BRANCH: master
Repo Added 01 Nov 2024 09:40PM UTC
Files 240
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH fix/decode-or-unknown-custom-reader
branch: fix/decode-or-unknown-custom-reader
CHANGE BRANCH
x
Reset
  • fix/decode-or-unknown-custom-reader
  • aac-asc-header
  • aac-main-and-asc-PR
  • adts-header-checks
  • av1-crypto-rap
  • av1-update
  • avc-bounds
  • avcc-encode-trailing-info
  • avcc-preserve-trailing-bytes
  • avs3
  • box-nesting-limit
  • chore-bump-min-go-1.18
  • chore-bump-min-go-1.19
  • chore/changelog-d
  • chore/changelog-union-merge
  • chore/codespell
  • chore/go-1.24-build-version
  • chore/prepare-v0.53.0
  • chore/prepare-v0.56.0
  • chore/prepare-v0.57.0
  • chore/prepare-v0.58.0
  • chore/prepare-v0.61.0
  • chore/remove-goreportcard-badge
  • ci/checkout-v7
  • codespell
  • codex/mp4ff-655-mandatory-track-children
  • colr-icc-decode
  • compressorname-length-clamp
  • dac4
  • decode-box-body-sr
  • defragment-core
  • defragment-hybrid
  • defragment-overlaps
  • docs-logo-svg
  • docs-readme-split
  • docs/benchmarks
  • docs/changelog-dec3-joc
  • docs/claude-md-history
  • docs/defragment-wording
  • docs/encoding-and-changelog
  • docs/fix-doc-comment-drift
  • docs/fix-misleading-doc-comments
  • docs/install-instructions
  • docs/mp4lens
  • docs/osc-badge-utm-2026-10-09
  • docs/readme-codec-table
  • docs/tfdt-relative-times
  • docs/trim-claude-md
  • elst-media-rate
  • esds-vocabulary
  • feat-aac-channel-config
  • feat-coll-box
  • feat-create-sei-nalu
  • feat-hevc-encrypt
  • feat-ivf
  • feat-lbli-sample-group
  • feat-lhvc-box
  • feat-linf-oinf-sample-groups
  • feat-mvhevc-builders
  • feat-mvhevc-cli
  • feat-trgr-track-group
  • feat-vexu-spatial-video
  • feat-vp-codec-sample-box
  • feat-vps-multilayer-extension
  • feat/alac-cookie
  • feat/av1-metadata-obu-cea608
  • feat/box-tree
  • feat/brands-check
  • feat/brands-defragmenter
  • feat/brands-general-type-box
  • feat/brands-generate
  • feat/caller-provided-memory
  • feat/clone-box
  • feat/discover-info-levels
  • feat/dolby-vision-dvh1-dvhe
  • feat/dref-resolver
  • feat/fragment-reset
  • feat/hevc-hdr-boxes
  • feat/mdat-payload
  • feat/motion-jpeg
  • feat/mov-decoder
  • feat/paint-model-subtitle-boxes
  • feat/piff
  • feat/pssh-widevine-playready
  • feat/quicktime
  • feat/quicktime-info-fields
  • feat/rsot-box
  • feat/saiz-v1-v2
  • feat/slice-header-into
  • feat/stream-read-mdat-data
  • feat/ttma-box
  • feat/vp09-cenc
  • feature-encryption-boxes
  • feature/exporttfhd
  • fix-32bit-bit-reads
  • fix-611-dataparts
  • fix-adts-frame-length
  • fix-adts-frequency-start-codes
  • fix-avcdecoderconfig
  • fix-bound-more-bitstream-counts
  • fix-boxseekreader-forward-seek
  • fix-co64-size-overflow
  • fix-container-children-bounds
  • fix-ftyp-styp-short-payload
  • fix-goreleaser-brew
  • fix-hdlr-reserved
  • fix-hevc-ps-dos
  • fix-hvcc-nalu-count
  • fix-interleaved-sidx-boxes
  • fix-mime-box
  • fix-senc-panic
  • fix-senc-robustness
  • fix-short-esds-issue-393
  • fix-sliceheader-spsid
  • fix-sps-num-ref-frames-overflow
  • fix-ssix-box
  • fix-stsc
  • fix-subs-box
  • fix-trailing-avc1-bytes
  • fix-typos
  • fix-vps-ols0-necessary-layers
  • fix/32bit-arch
  • fix/708-711-712
  • fix/annexb-trailing-zeros
  • fix/avc-deblock-offsets
  • fix/avc-hrd-cpb-cnt
  • fix/avc-inband-parameter-sets
  • fix/avc-param-set-ranges
  • fix/avc-parameter-sets-eof
  • fix/avc-pps-scaling-lists
  • fix/box-versions-above-1
  • fix/cenc-encrypt-conformance
  • fix/cenc-increment
  • fix/cmd-missing-boxes
  • fix/container-error-bounded
  • fix/container-size-underflow
  • fix/crop-stsc-first-chunk
  • fix/crop-tables
  • fix/crypto-missing-boxes
  • fix/databox-type-locale
  • fix/decode-missing-boxes
  • fix/decoders-exact-box-size
  • fix/dos-limits
  • fix/empty-trak-subtitle-header
  • fix/external-data-references
  • fix/extract-protect-avc3-hev1
  • fix/file-encodesw-mfra
  • fix/get-sample-data-indexing
  • fix/hevc-ctb-size
  • fix/hevc-multilayer-ext-sps
  • fix/hevc-slice-deblocking-inference
  • fix/issyncsampleflags
  • fix/lazy-decode-hardening
  • fix/leva-grouping-type
  • fix/mdat-mixed-data
  • fix/moov-decode-linear
  • fix/nalu-length-size-checks
  • fix/oob-panics
  • fix/prft-decode
  • fix/quicktime-meta-encodesw
  • fix/quicktime-mvhd-tkhd-mdhd
  • fix/quicktime-udta-terminator
  • fix/quicktime-visual-sample-entry
  • fix/sample-data-inverted-interval
  • fix/sample-table-missing-boxes
  • fix/sdtp-entry-depends-on
  • fix/segment-missing-boxes
  • fix/segmenter-last-sample
  • fix/sei-nalu-short-panic
  • fix/sgpd-description-length-bound
  • fix/slice-header-seq-param-id
  • fix/stsc-containing-chunks
  • fix/stsc-sample-description-id
  • fix/stts-decode-time-bounds
  • fix/top-level-box-attribution
  • fix/traf-requires-tfhd
  • fix/trun-mdat-bounds
  • fix/uuid-mss-sm
  • fix/vvc-decconfrec-nalus
  • flac
  • fuzz-box
  • go-releaser
  • golangci-lint-v2
  • handle-trailing-avc1-bytes
  • hevc-ref-idx-255
  • hevc-vps
  • iMro0t-feature-encryption-boxes
  • iMro0t-fix-avcdecoderconfig
  • improve-av1
  • improved-crypt-tools
  • issue-492
  • labl-box
  • lpcm-format-flags
  • master
  • mdat-header-size
  • mdhd-dur-info
  • minimal-ac4
  • more-robust-decode
  • mp4-blackbox-test
  • mpeg-h
  • mvhevc-help-doc
  • nalu-length-size
  • nalu-length-size-helpers
  • new-pssh-func
  • normalize-quicktime
  • opus
  • parse-joc-dolby-atmos
  • patch-1
  • perf-read-payload
  • perf-stream-getter-reads
  • perf/add-full-samples
  • perf/addfullsamples-always-parts
  • perf/bits-av1-allocs
  • perf/buffer-cmd-writers
  • perf/buffer-writetofile
  • perf/built-fragment-offsets
  • perf/bulk-table-decode
  • perf/cipher-hoist
  • perf/decode-allocs
  • perf/ebsp-allocs
  • perf/encode-allocs
  • perf/encrypt-allocs
  • perf/fragment-decoder
  • perfloop-pr-open-5vngg69nsk
  • perfloop-pr-open-77mvkyshvr
  • perfloop-pr-open-jjgn99rrgp
  • perfloop-pr-open-n6293cbpva
  • perfloop-pr-open-yqdd5wtxyv
  • prepare-v0.60.0
  • pslister-nallister-codecs
  • qt-legacy-audio-entries
  • qt-sound-descriptions
  • refactor/styp-delegate
  • release-v0.59.0
  • release-v0.62.0
  • release-v0.62.1
  • release-v0.63.0
  • release/v0.51.0
  • release/v0.52.0
  • release/v0.54.0
  • release/v0.55.0
  • remove-homebrew-cask
  • return-partial-files
  • sampleflags-test
  • sei-recovery-point
  • spherical-v1-no-xml
  • sphericalv1
  • stream-process
  • test-header-parsing
  • test-visualsampleentry
  • tkhd-preserve-matrix
  • update-changelog
  • update-coverage-job
  • update-docs
  • update-make
  • usac-asc
  • v0.48.0
  • v0.49.0
  • v0.50.0
  • vtpl1-master
  • vvc
  • vvc-nal-headers
  • wave-box
  • wave-box-followups
  • weird-dac3

04 Nov 2026 01:06PM UTC coverage: 84.235% (+0.002%) from 84.233%
41835158381

Pull #702

github

tobbee
fix(mp4): read the fields of QuickTime atoms from a reader that is not a FixedSliceReader

Since 6f2cdd6, decodeOrUnknownSR reads the payload with one ReadBytes and decodes it from a bits.FixedSliceReader of its own. A bits.SliceReader that records the reads, as mp4lens does to show the byte layout of a box, then saw one read of the whole payload instead of the fields, for alis, chan, chpl, gmin, keys, mean, tcmi, tmcd, clef/prof/enof, text, tx3g, ftab and the ProRes sample entries.

decodeOrUnknownSR now decodes from a bits.FixedSliceReader as before, once, from a reader of its own. From another bits.SliceReader, decodeCopyOrUnknownSR first decodes a copy of the payload from a bits.FixedSliceReader and, if that works, decodes again from the reader, or returns an UnknownBox. The copy decodes the boxes below it once each, so the time grows with the square of the nesting instead of doubling per level, and boxes nested far deeper than MaxBoxDepth still give ErrBoxTooDeep.

TestDecodeOrUnknownOnOtherReader counts the reads in the payloads of chan, alis and a QuickTime text entry on a recording reader (1 each before the fix), and checks that a too short alis becomes an UnknownBox that ends where the box ends. TestNestedBoxesOnOtherReader decodes 64 nested gmhd, tapt and tmcd boxes within 10 s and gets ErrBoxTooDeep for 128.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01EagxH5xE2UAmVD7tQWREtL
Pull Request #702: fix(mp4): read the fields of QuickTime atoms from a reader that is not a FixedSliceReader

13 of 15 new or added lines in 1 file covered. (86.67%)

26998 of 32051 relevant lines covered (84.23%)

0.84 hits per line

Relevant lines Covered
Build:
Build:
32051 RELEVANT LINES 26998 COVERED LINES
0.84 HITS PER LINE
Source Files on fix/decode-or-unknown-custom-reader
  • Tree
  • List 237
  • Changed 1
  • Source Changed 0
  • Coverage Changed 1
Coverage ∆ File Lines Relevant Covered Missed Hits/Line

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
41835158381 fix/decode-or-unknown-custom-reader fix(mp4): read the fields of QuickTime atoms from a reader that is not a FixedSliceReader Since 6f2cdd6, decodeOrUnknownSR reads the payload with one ReadBytes and decodes it from a bits.FixedSliceReader of its own. A bits.SliceReader that record... Pull #702 04 Nov 2026 01:07PM UTC tobbee github
84.23
See All Builds (789)
  • Repo on GitHub
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE TRIAL · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc