18F / cg-deck

71%

master: 71%

LAST BUILD ON BRANCH jk-css-modules

branch: jk-css-modules

CHANGE BRANCH

x

Reset

• jk-css-modules
• master
• deploy
• staging
• travis
• staging-alpha
• concourse
• deprecated
• travis-deploy
• 1.0.0
• home-update
• ms-sidebar_context
• notice-update
• ms-content_on_pages
• js-fix-client-setup
• govcloud-deploy
• ms-limit_current_user_actions
• ms-content_updates
• govcloud-fix
• jk-add-memory-units
• jk-marketplace-service-desc
• jk-css-cleanup
• ms-upgrade_npm
• ms-continue_fixtures
• jk-no-apps
• ms-release-1.1.0
• js-app-name-deploy
• jk-no-dev-ga
• ms-modify_nr_config
• 1.1.0
• ms-zero_mb_formatting
• ms-accessibility_table_scope
• jk-route-domain
• ms-alphabetize_sidenav
• notice
• ms-update_cg_style-093
• ms-add_uaa_dashboard_icon
• jk-loading-bugs
• release-1.2.0
• ms-fix_space_page_loading
• 1.2.0
• ms-fix_checkboxes
• ms-additional_space_initial_load_fixes
• release-1.2.1
• 1.2.1
• ms-cache_phantomjs2
• ms-change_deployment_names
• ms-change_go_names

Build # 931

Build Type

push

travis-ci

Committed by jeremiak

Commit Message

Use single css file for all components

CSS modules is a cool idea, but our implementation got a bit
complex. We were importing the individual component files
from the style library, meaning that anybody working on a
component had to know not only that a class was in cloudgov-
style but also which file it was in. This was a lot of work
for something as simple as adding a class.

Now, all components just use the final, generated output css
from cloudgov-style so that any class in the library should
work pretty well in any component. I kept the .styler()
convention mostly in place to minimize changes.

The best illustration of how this changes improves code
legibility is in navbar.jsx right after render() begins.
Where we used to have to know which component file a class
was in, now we can simply use any class from the style
library.

Refs #350

Run Details

237 of 334 relevant lines covered (70.96%)

3.17 hits per line