929
71%
master: 71%

Ran 13 Jul 2016 01:36AM UTC

Jobs 1

Files 8

Run time 0s

Badge

Embed ▾

pending completion

Build # 929

Build Type

push

travis-ci

Committed by

jeremiak

Commit Message

Use single css file for all components

CSS modules is a cool idea, but our implementation got a bit
complex. We were importing the individual component files
from the style library, meaning that anybody working on a
component had to know not only that a class was in cloudgov-
style but also which file it was in. This was a lot of work
for something as simple as adding a class.

Now, all components just use the final, generated output css
from cloudgov-style so that any class in the library should
work pretty well in any component. I kept the .styler()
convention mostly in place to minimize changes.

The best illustration of how this changes improves code
legability is in navbar.jsx right after render() begins.
Where we used to have to know which component file a class
was in, now we can simply use any class from the style
library.

Refs #350

Run Details

237 of 334 relevant lines covered (70.96%)

3.17 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
1	929.1	13 Jul 2016 01:36AM UTC	0	70.96	Travis Job 929.1

Source Files on build 929

Coverage	∆	File	Lines	Relevant	Covered	Missed	Hits/Line

18F / cg-deck / 929
71%
master: 71%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 929

18F / cg-deck / 929 71% master: 71%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 929

18F / cg-deck / 929
71%
master: 71%

README BADGES
x