18F / cg-deck

71%

master: 71%

LAST BUILD ON BRANCH jk-loading-bugs

branch: jk-loading-bugs

CHANGE BRANCH

x

Reset

• jk-loading-bugs
• 1.0.0
• 1.1.0
• 1.2.0
• 1.2.1
• concourse
• deploy
• deprecated
• govcloud-deploy
• govcloud-fix
• home-update
• jk-add-memory-units
• jk-css-cleanup
• jk-css-modules
• jk-marketplace-service-desc
• jk-no-apps
• jk-no-dev-ga
• jk-route-domain
• js-app-name-deploy
• js-fix-client-setup
• master
• ms-accessibility_table_scope
• ms-add_uaa_dashboard_icon
• ms-additional_space_initial_load_fixes
• ms-alphabetize_sidenav
• ms-cache_phantomjs2
• ms-change_deployment_names
• ms-change_go_names
• ms-content_on_pages
• ms-content_updates
• ms-continue_fixtures
• ms-fix_checkboxes
• ms-fix_space_page_loading
• ms-limit_current_user_actions
• ms-modify_nr_config
• ms-release-1.1.0
• ms-sidebar_context
• ms-update_cg_style-093
• ms-upgrade_npm
• ms-zero_mb_formatting
• notice
• notice-update
• release-1.2.0
• release-1.2.1
• staging
• staging-alpha
• travis
• travis-deploy

Build # 1006

Build Type

push

travis-ci

Committed by jeremiak

Commit Message

Fix user store so tests pass

We had previously been setting .fetching at the top of each
of the handler functions in the stores. The problem with this is
that changing the fetching value will trigger a change event,
which might fire before the data that was retrieved from the API
has been merged into the stores. The result is a flash of content
like bug where the user sees a flash of "No apps", etc.

It looks pretty weird to set the value in two places like this,
but I set it after the merge data operation has been completed
and in the case that the request retrieved no data.

Run Details

237 of 334 relevant lines covered (70.96%)

3.17 hits per line