18F / cg-deck

71%

master: 71%

LAST BUILD ON BRANCH jk-no-apps

branch: jk-no-apps

CHANGE BRANCH

x

Reset

• jk-no-apps
• 1.0.0
• 1.1.0
• 1.2.0
• 1.2.1
• concourse
• deploy
• deprecated
• govcloud-deploy
• govcloud-fix
• home-update
• jk-add-memory-units
• jk-css-cleanup
• jk-css-modules
• jk-loading-bugs
• jk-marketplace-service-desc
• jk-no-dev-ga
• jk-route-domain
• js-app-name-deploy
• js-fix-client-setup
• master
• ms-accessibility_table_scope
• ms-add_uaa_dashboard_icon
• ms-additional_space_initial_load_fixes
• ms-alphabetize_sidenav
• ms-cache_phantomjs2
• ms-change_deployment_names
• ms-change_go_names
• ms-content_on_pages
• ms-content_updates
• ms-continue_fixtures
• ms-fix_checkboxes
• ms-fix_space_page_loading
• ms-limit_current_user_actions
• ms-modify_nr_config
• ms-release-1.1.0
• ms-sidebar_context
• ms-update_cg_style-093
• ms-upgrade_npm
• ms-zero_mb_formatting
• notice
• notice-update
• release-1.2.0
• release-1.2.1
• staging
• staging-alpha
• travis
• travis-deploy

Build # 934

Build Type

push

travis-ci

Committed by jeremiak

Commit Message

Set fetching to false after store.merge

I think one of the reasons #448 might have been happening
is because the change event was emitted when fetching
was set at the top of the action handling code. In this way,
the listening component was updated while fetching was false
and the newly received data was being merged into the existing
data. The result of this would be a flash of content.

I noticed this was happening in the space store and the
app store so I set fetching to false in the merge callback.

Run Details

237 of 334 relevant lines covered (70.96%)

3.17 hits per line