RobotWebTools / rclnodejs / 43194708371

91%

push

github

Wake executor before synchronizing waitable handles (#1682)

Handle synchronization could block indefinitely during an idle `spin(-1)`: the worker held the handle read lock inside `rcl_wait()`, while the JS thread waited for the write lock without waking the worker.

- Route `ShadowNode` synchronization through `Executor::SynchronizeHandles()`, supplying the internal interrupt guard only when the executor is running.
- Publish `is_synchronizing_` and trigger the interrupt guard before acquiring the handle write lock, allowing updates to proceed during long or infinite waits.
- Replace `sync_handle_sem_` with a condition-variable wait on `!is_synchronizing()`, preventing accumulated permits from earlier synchronizations from satisfying a later wait.
- Use a scope guard to clear the synchronization flag and notify waiters on normal and exceptional exits, coordinating notification with the waiter's mutex.
- Recheck pending synchronization after acquiring the handle read lock so the worker cannot enter another infinite wait while an update is pending.
- Add a bounded child-process regression covering repeated timer, subscription, client, service, and guard creation/removal during infinite spinning.

Fix: #1683

2390 of 2790 branches covered (85.66%)

Branch coverage included in aggregate %.

18204 of 19753 relevant lines covered (92.16%)

295.58 hits per line