RobotWebTools / rclnodejs / 43190346735

91%

push

github

Fix entity teardown and pending native handle lifetimes (#1681)

Keep retained JS entity wrappers consistent with native resource destruction and prevent released wrappers from remaining cached or referenced by pending native dispatch.

- Reuse `_destroyEntity()` during `Node.destroy()` so retained publishers, subscriptions, clients, services, guards, and QoS events report their destroyed state; clear the node's event collection.
- Destroy action clients and servers over collection snapshots to avoid skipping entries when destruction modifies the arrays.
- Schedule coalesced cleanup of released-handle references with `setImmediate().unref()`, without requiring another callback dispatch, while preserving `Node.execute()` cleanup.
- Add `PruneRemovedReadyHandles()` after rebuilding the active native handle lists. Remove unregistered queued pointers under the existing locks while preserving live handles and queue order.
- Extend JS regression coverage for retained wrappers, QoS events, multi-action node/context teardown, repeated destruction, non-spinning cleanup, and pending ready batches.
- Measure `syncHandles()` independently of entity creation while retaining the existing 75 ms bound, and adjust the guard regression's trigger order to avoid the known upstream RMW notification race.
- Add child-process failure diagnostics covering exit status, runtime environment, loaded addon, stdout, stderr, and progress through the ready-queue test.

Fix: #1680

2391 of 2791 branches covered (85.67%)

Branch coverage included in aggregate %.

29 of 29 new or added lines in 2 files covered. (100.0%)

18204 of 19753 relevant lines covered (92.16%)

294.54 hits per line