FlexMeasures / flexmeasures / 41550092370

88%

push

github

Build only the listed chart types, and leave the chart defaults alone (#2801)

* Build only the listed chart types, and answer other chart-type values with a 422

chart_type_to_chart_specs looked up any function or dict in the chart module by the name a request gave,
so a chart request could reach helpers and module-level specs that are not chart types.
It now builds only the chart types it lists:
the sensor chart types (bar_chart, histogram, daily_heatmap, weekly_heatmap and heatmap) and the two asset chart builders.
The sensor chart endpoint of the UI-support API (also under /api/dev) and the asset chart endpoint check chart-type against those lists.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01UBBvKZkzbfEPKctwTN8SDf
Signed-off-by: F.N. Claessen <claessen@seita.nl>

* Apply the chart defaults to a copy of the chart specs

Chart builders embed module-level specs, such as REPLAY_RULER and FIELD_DEFINITIONS, and apply_chart_defaults adds to the specs it is given.
It now works on a deep copy, as does its merge with LEGIBILITY_DEFAULTS, so building a chart cannot change what later charts start from.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01UBBvKZkzbfEPKctwTN8SDf
Signed-off-by: F.N. Claessen <claessen@seita.nl>

* Add changelog entries for the chart type checks

The PR number is not known yet, so the entries link to PR #XXXX.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01UBBvKZkzbfEPKctwTN8SDf
Signed-off-by: F.N. Claessen <claessen@seita.nl>

* Store the validated chart type in the session, not the raw request value

A sensor chart request sending both chart-type and chart_type is validated on the canonical key,
but the session took the legacy key's raw value, which then broke the sensor page's own chart requests.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Cl... (continued)

22 of 22 new or added lines in 4 files covered. (100.0%)

22995 of 26282 relevant lines covered (87.49%)

0.87 hits per line