FlexMeasures / flexmeasures / 41600545056

88%

push

github

perf: load only the data each asset chart type draws (#2790)

* perf: load only the data each asset chart type draws

On an asset with charge points, the Default chart and the Charge Points chart
shared one chart data request, which loaded every sensor in sensors_to_show.
The Default chart skips the "Charge Point sessions" graph, so its session
sensors were loaded and thrown away, and the Charge Points chart likewise
loaded everything to draw a few graphs.

GET /assets/<id>/chart_data now accepts chart-type and returns only the data
of the sensors that chart type draws (GenericAsset.chart_sensors). Without it,
it returns every sensor's data, as before. The asset page sends the selected
chart type, and loads that chart's data when the user switches charts; the
chart data cache no longer reuses records loaded for another chart type.

Closes #2789.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Ahmad-Wahid <ahmedwahid16101@gmail.com>

* Stop a running replay before switching charts, and name the companion graph titles

Switching between the asset charts reloaded the data without stopping a replay,
which would keep drawing the previous chart type's data; and stopping a replay
redraws the Vega-Lite chart, so the reload now waits for it.

The "Prices" and "Power flow by type" titles were spelled out again in
GenericAsset.chart_sensors; both now come from belief_charts.py.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Ahmad-Wahid <ahmedwahid16101@gmail.com>

* api/v3_0/tests: isolate asset chart data tests with fresh_db

Co-authored-by: Ahmad-Wahid <59763365+Ahmad-Wahid@users.noreply.github.com>

* Load the companion graphs the Charge Points chart draws, whatever the case of their titles

The Vega-Lite Charge Points chart capitalizes graph titles before matching them,
but chart_sensors compared the raw titles,
so a graph titled "prices" or "power flow by type" was drawn without its data.
One helper in belief... (continued)

42 of 44 new or added lines in 4 files covered. (95.45%)

23074 of 26312 relevant lines covered (87.69%)

0.88 hits per line