ruby-grape / grape / 41538965478

100%

push

github

Remove unused ParamsScope#root? and cover the placeholder skip in validate_elements! (#3050)

`ParamsScope#root?` lost its only caller in #3010, which took the
root-scope check out of ValuesValidator. Nothing in lib, spec or
grape-swagger calls it, so it is removed rather than specced.

`Base#validate_elements!` skips the placeholder (`EmptyOptionalValue`)
that `map_params` leaves for an element of an Array that left an
optional scope out. The fast path meets that placeholder only when a
required Hash param is sent as an Array, and no spec sent one, so the
taken branch of that `next` never ran. The new spec sends
`order: [{}, { items: { sku: 'A' } }]` to `requires :order, type: Hash`
holding `optional :items, type: Array do requires :sku end`. Without
the skip, the answer also blames the order that never sent `items`
with `order[items][0][sku] is missing`; with it, the fast path answers
as the iterator path does.

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>

1513 of 1513 branches covered (100.0%)

Branch coverage included in aggregate %.

4530 of 4530 relevant lines covered (100.0%)

30738.62 hits per line