hyperledger-labs / fabric-smart-client / 41297325990

92%

Build Type

push

github

Committed by web-flow

Commit Message

fix: reject lying endorsements and keep sessions apart per sender (#2419)

Adds unit tests for the decision points between another organisation's FSC node and a node's state, and rejects a Fabric-x proposal response that verified without any signature being checked.

On Fabric, collectEndorsementsView rejects a validly signed endorsement over different results, an empty response and garbled response bytes, and appends nothing in each case. The existing unbound-party test shares the same fixture.

On Fabric-x, VerifyEndorsement checks one signature per namespace of the response payload, so a payload with no namespaces and an empty signature list passed without any check. It is now rejected. The tests also cover a payload swapped under a valid signature, an empty response, and garbled bytes given to the transaction manager. Fabric-x compares no results: a response's results are its payload, which the endorser's signature covers.

In comm, a message that reuses another sender's session ID goes to the master session instead of that sender's session.

Fixes #2390

Signed-off-by: Said Altury <Said.Altury@ibm.com>
Signed-off-by: Marcus Brandenburger <bur@zurich.ibm.com>

Coverage Stats

3 of 3 new or added lines in 1 file covered. (100.0%)

5 existing lines in 2 files now uncovered.

30577 of 33420 relevant lines covered (91.49%)

1279.18 hits per line