hyperledger-labs / fabric-smart-client / 41297044285

91%

Build Type

push

github

Committed by web-flow

Commit Message

fix(fabric): never set a valid transaction back to busy (#2420)

Writing Busy for a transaction the vault holds as Valid replaced the status, so the vault reported a committed transaction as pending. The ON CONFLICT DO UPDATE of SetStatusesBusy, which Store runs before marking a commit Valid, and of SetStatuses with a Busy code now skips rows that are Valid. The status cache drops its entry on a Busy write instead of caching Busy, so it rereads the status the store kept.

A vault store test checks on memory, SQLite and Postgres that a committed transaction stays Valid after a Busy write.

Fixes #2391

Signed-off-by: Said Altury <Said.Altury@ibm.com>

Coverage Stats

16 of 16 new or added lines in 2 files covered. (100.0%)

7 existing lines in 4 files now uncovered.

30572 of 33417 relevant lines covered (91.49%)

1278.28 hits per line