IJHack / QtPass / 41277968541

93%

push

github

Pass: warn when a path breaks the spelling rule; read settings once (#2101)

* Pass: warn when a path breaks the spelling rule; read settings once

Two follow-ups from Henk's reviews, tracked in #2094:

- The path rule in the Pass docs (#2098) now has a guard. A path spelled
  through the target of a linked store root, rather than as the store is
  configured, is logged as a warning by refuseLinkedPath(), which every
  operation goes through; tests catch a caller that starts handing one
  over. PathValidator::isTargetSpelled() names exactly that spelling, so
  paths outside the store (legitimate input that the checks refuse, and
  that tests send on purpose) are not flagged. Init() places such a
  folder itself (#2097) and passes placed=true, so it does not warn.
- ConfigDialog read the whole settings file on every validate(), per
  keystroke in the profile form, only for the GPG home it does not edit.
  The gpg environment is now built once, on first use (#2100).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01VJygpMUf461yZgfAqwMJ6d
Signed-off-by: Anne Jan Brouwer <brouwer@annejan.com>

* ConfigDialog: build the gpg environment each check, read settings once

Caching the environment kept the one of the first check: a GPG home
that did not exist yet (and appears while the dialog is open, as when a
key is generated from it) was never used, and a primary key and its
subkey were not recognised as one signer. The settings are still read
once; the environment, which checks whether the home exists, is built
on every check. Found by CodeRabbit on #2101.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01VJygpMUf461yZgfAqwMJ6d
Signed-off-by: Anne Jan Brouwer <brouwer@annejan.com>

* Fix: rebuild GPG env each time; settings read once

* Drop the Python caches from 8caabfd40; ignore them

8caabfd40 committed two __pycache__/*.pyc files left by runnin... (continued)

26 of 26 new or added lines in 5 files covered. (100.0%)

10034 of 10829 relevant lines covered (92.66%)

399.08 hits per line