IJHack / QtPass / 41227817669

93%

Build Type

push

github

Committed by web-flow

Commit Message

Profiles: look signers up in the keyring that signs (#2100)

Follow-ups to #2099 from Henk's review:

- The lookup ran in the inherited environment, while profiles sign with
  the configured GPG home: a key ID could resolve to another key there.
  It now runs with ProfileInit::gpgEnvironment() (the system environment
  with GNUPGHOME set as withGpgHome() sets it), built once per validate,
  and the home is part of the cache key.
- A key ID is matched against the pub/sub record's own ID field instead
  of a fingerprint's tail: a v5/v6 key's ID is its fingerprint's head,
  so a 16-hex ID of such a key was never resolved.
- A key that more than one block holds (a short ID, which collides
  easily) resolves to nothing, so the warning cannot name a profile
  that shares no key.
- --batch --no-auto-check-trustdb keeps the blocking first lookup from
  running a trustdb check on a large keyring.


Claude-Session: https://claude.ai/code/session_01VJygpMUf461yZgfAqwMJ6d

Signed-off-by: Anne Jan Brouwer <brouwer@annejan.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>

Coverage Stats

30 of 30 new or added lines in 3 files covered. (100.0%)

1 existing line in 1 file now uncovered.

10016 of 10811 relevant lines covered (92.65%)

400.93 hits per line