solidjs / solid / 41106457369

78%

main: 89%

push

github

fix(signals): a lane's held reader settling never makes the flush join the lane (#4440) (#4477)

* fix(signals): a lane's held reader settling never makes the flush join the lane (#4440)

A landing's settle walk joins the flush to the transaction of each held
reader it releases (`joinFuture(txOf(node))`). A render or user effect a
guess's lane holds has that lane as its transaction, so the flush took the
lane as its transaction. The lane was dissolved later in the same flush (a
correction), and every node born held after that (the rows `<For>` mounted
for the refreshed list) was listed on the dead lane and never committed: the
row rendered with every hole empty. Lane work never makes its node the
transaction's (D-37), so the walk now skips a reader held by a lane.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_015hPxMkC3jg3Uivh65gvaf2

* chore(size): record #4440's sizes over next @ 7135a77a

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_015hPxMkC3jg3Uivh65gvaf2

* chore(size): record #4440's sizes over next @ 131ceb8c

The simple-app floor goes over its frozen cap (9,789 B brotli, +22 B
minified over the recorded) and needs a Size-Exception in the PR body.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_015hPxMkC3jg3Uivh65gvaf2

* chore(size): re-record #4440's sizes over next @ e49b0c76

Two frozen floors go over their caps (each +24 B minified over the
recorded): the simple-app floor (9,790 B brotli) and the hydrating
(no stores) floor (18,758 B). Both need a Size-Exception in the PR body.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_015hPxMkC3jg3Uivh65gvaf2

* chore(size): re-record #4440's sizes over next @ ab3d2add

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_015... (continued)

790 of 1090 branches covered (72.48%)

Branch coverage included in aggregate %.

1125 of 1362 relevant lines covered (82.6%)

29.8 hits per line