solidjs / solid / 41110875339

78%

main: 89%

push

github

fix(signals): a held frame's leaf is the hold's own work, not its verdict reader (E2) (#4473)

* fix(signals): a held frame's leaf is the hold's own work, not its verdict reader (E2)

A render effect in a frame a held pass built (CONFIG_HELD_FRAME, e.g. the
branch `<Show when={y() > 0}>` opens under an action holding `y`) re-run
by the hold's next step showed two ways depending on memo wrapping:

- inline `latest(y)`: `route` seated it as the hold's verdict reader, so
  its run went out at the verdict lane's reveal, ahead of its frame;
- `createMemo(() => latest(y))` read plainly: `laneRead`'s L7' arm served
  the memo's staging as the hold's own value and the run waited for the
  landing (and a later run, with nothing staged, entered the verdict lane
  through `enterLane`).

`[10, 20]` beside `[10]` for one hold; with #4455, the two-hold review
shape (`[latest(y), m()]` inline vs a memo of it, or split leaves) the
same. A member of the hold's held frame is born in its world: it reads
plainly and a probe does not rescue it (D-25, as #4426/#4454 for its
reads), and its runs are the frame's, which commits with the hold (D-27's
joined pass, A29 ruling A). `route` and `enterLane`'s verdict arm now
leave it the frame's when the lane's hold is the one it was born into;
every form waits for the landing (the branch is not on screen before it).
The reader-seat table carries the same clause (test-only).

#4455's pin (`verdict-seat-merged-lane-4427`) asserted the inline leaf
running ahead of its held frame (`1/20` at A's step); it now expects the
frame's `1/10` until B's landing, and gains the mainline-mount contrast
(`<Show when={latest(y) > 0}>`), which still shows `1/20`.

Lives in verdict.ts / lanes.ts only: 0 B on every floor.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_015hPxMkC3jg3Uivh65gvaf2

* chore(size): record the held-frame verdict clause's cost on the lane pages

Measured locally (linux) o... (continued)

790 of 1090 branches covered (72.48%)

Branch coverage included in aggregate %.

1125 of 1362 relevant lines covered (82.6%)

29.69 hits per line