bootstrapworld / codemirror-blocks / 41089425111

95%

push

github

fix(state): forget marks on blocks that are gone, and say marks do not survive a mode switch

Each mode has its own CodeMirror, so a mark made with markText dies when the
mode changes, but the store's markedMap kept an entry (a dead TextMarker keyed
by a block id that the new AST no longer has) for every mark, forever. SET_AST
now drops the entries of blocks it does not have, like it already did for
collapsed blocks, selections and the focus. A mark on a block that stays still
stays while other blocks are edited.

The comments in ToggleEditor claimed marks were recorded and re-rendered on a
mode switch, which has not been true for a long time; they now say they are
dropped (#571). The commented-out "preserve marks across mode transitions" test
is replaced by real specs: a mark shows on its block, is forgotten with the
block, stays through edits elsewhere, and is cleared by a mode switch (two of
them fail without the fix), plus an it.failing for the gap itself, which turns
red when marks start to survive.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

2136 of 2476 branches covered (86.27%)

1 of 1 new or added line in 1 file covered. (100.0%)

3723 of 3958 relevant lines covered (94.06%)

5188.64 hits per line