bootstrapworld / codemirror-blocks / 41081020778

95%

push

github

feat(search): bring search back, as a dialog built on the editor's own

F3, Ctrl-F (Cmd-F on a Mac) opens the Search Settings dialog, with the two
searchers that were left in the code: by text (ignore case, exact match, regular
expression) and by kind of block. Enter closes the dialog and goes to the first
match; PageDown and PageUp go to the next and previous match, on from the other
end of the document, with a sound, past the last one. A match is never the block
that already has the focus, and with nothing chosen yet the keys do nothing but
say so. Search was taken out in #502.

It is now a hook, useSearch, whose commands reach the keymap through
appHelpers.search (like the shortcuts dialog does through showDialog) instead of
a class component wrapped around the whole editor, so its state lives with the
rest of the editor's React state and the code that was commented out in the
keymap is real again. The dialog takes an onAfterClose: closing it gives focus
back to where it was, so going to the first match has to wait until then (the
browser test caught this: in jsdom the match kept the focus). Searching from
before the first character when wrapping also fixes the first block being
skipped when it is the match.

spec/search-test.tsx (17 tests) covers opening, closing, text and block-type
search, stepping and wrapping with the sounds, and the options; e2e/search.e2e.ts
(5) does the same in Chromium. The old "search keys are inert" specs are gone.
Search.tsx goes from 0% to 97% of lines.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

2133 of 2476 branches covered (86.15%)

82 of 85 new or added lines in 3 files covered. (96.47%)

3716 of 3955 relevant lines covered (93.96%)

5145.33 hits per line