bootstrapworld / codemirror-blocks / 41075429481

95%

push

github

fix(api): a selected block no longer comes with a phantom cursor selection

Selecting a block (setSelection, setSelections, or clicking it) leaves the text
editor's own cursor wherever it was, because CodeMirror ignores an empty list of
ranges. listSelections then reported that cursor as a second, empty selection
next to the block: getSelections() returned ["(+ 1 2)", ""], getSelection()
ended with a stray separator, and replaceSelection() replaced the block and
also inserted the new text at the cursor (typically the end of the document).

listSelections now leaves the cursor out when blocks are selected; text that is
really selected between blocks stays, and with no block selected the cursor is
still the selection, as in CodeMirror.

Three specs in api-test.ts had recorded the old results ("(+ 1 2)MOO", and an
extra empty selection); they now expect the block alone. New specs in
api-selection-test.ts: one block, several blocks, replaceSelection, the cursor
with no block selected, and text selected next to a block. Three of them fail
without the fix.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

2043 of 2470 branches covered (82.71%)

9 of 10 new or added lines in 1 file covered. (90.0%)

3544 of 3930 relevant lines covered (90.18%)

4501.54 hits per line