hyperledger-labs / fabric-smart-client / 40876083621
92%

DEFAULT BRANCH: main
Ran
Jobs 0
Files 0
Run time –
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
40876083621

push

github

web-flow 
test: move the root module's Ginkgo suites to testify and lint against gomega (#2379)

The unit tests in events/simple, metrics/disabled, metrics/prometheus,
view/client, web/server and web/server/middleware assert with testify.
Each Ginkgo spec is a subtest, setup from BeforeEach runs inside every
subtest, and the suite files are gone. The tests now run with -count
above 1, -shuffle and t.Parallel().

Every test runs in parallel except TestProvider in metrics/prometheus:
the provider registers through prom.Register, so each subtest points
the process-wide prom.DefaultRegisterer at its own registry and restores
it on cleanup. The "implements metrics.Provider" spec is a compile-time
assertion. The web/server tests build their TLS material in memory and
wait on ifrit's channels with a timeout instead of Eventually and
Consistently.

A depguard rule in .golangci.yml rejects gomega and Ginkgo imports in
test files. It is excluded for ^integration/, which golangci-lint
matches relative to the config, because the integration suites are
Ginkgo and nwo asserts through gomega. docs/agents/testing.md states
the framework split and when a unit test may skip t.Parallel().

gomega and Ginkgo stay in the root go.mod as indirect dependencies:
logging_test_utils.go imports fabric-lib-go's floggingtest.

Each touched package keeps its test count (prometheus: 20 subtests and
the compile-time assertion for 21 specs) and passes
go test -race -count=3 -shuffle=on.

Closes #2363

Signed-off-by: Marcus Brandenburger <bur@zurich.ibm.com>
Source Files on build 40876083621
Detailed source file information is not available for this build.