hyperledger-labs / fabric-smart-client / 40875981859
91%

DEFAULT BRANCH: main
Ran
Jobs 25
Files 494
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 91.481% (+0.003%) from 91.478%
40875981859

push

github

web-flow 
test(nwo): restart the Fabric-x committer without its mock orderer (#2377)

The faultrecovery spec "survives committer restart" was pending because a restarted committer never committed again. StopCommitter and StartCommitter ran docker stop and docker start on the committer test container, which also runs the mock orderer. The mock orderer keeps its blocks in memory, so after the restart it served only the genesis block, while the sidecar recovered from its database and asked for block 2. Delivery then waited forever and the next transaction stayed unknown.

StopCommitter now kills only the five committer services inside the container (verifier, vc, query, coordinator, sidecar) and waits until they exit. StartCommitter starts them again with the image's run script through docker exec. Postgres and the mock orderer keep running, and the restarted sidecar fetches block 2 from the same orderer. StartCommitter forwards the exec's output to the container logger and fails as soon as the run script exits, without waiting for the 90 s readiness timeout.

The new docker.Exec helper runs a command in a container and fails on a non-zero exit code or after one minute. containerCmd takes the run-script operations, so launch and restart build the command the same way. followLogsAndWait is split into forwardLogs and waitUntilReady.

The spec runs again, and make integration-tests-fabricx-faultrecovery passes. docs/agents/integration-tests.md describes the restart and notes that a Fabric-x spec cannot restart the orderer, because the committer test container's mock orderer loses its blocks on restart.

Fixes #2268

Signed-off-by: Marcus Brandenburger <bur@zurich.ibm.com>

30088 of 32890 relevant lines covered (91.48%)

1235.88 hits per line

Coverage Regressions

Lines Coverage ∆ File
6
94.67
-0.89% platform/view/services/comm/host/websocket/ws/multiplexed_provider.go
4
84.54
-2.06% platform/fabric/core/generic/events/listenermanager.go
Jobs
ID Job ID Ran Files Coverage
1 itest-fabric-iou-libp2p - 40875981859.1 457
37.12
GitHub Action Run
2 itest-fabric-events - 40875981859.2 452
29.67
GitHub Action Run
3 utest-extensions - 40875981859.3 8
52.69
GitHub Action Run
4 itest-fsc-pingpong - 40875981859.4 252
35.29
GitHub Action Run
5 itest-fabricx-iou - 40875981859.5 479
30.36
GitHub Action Run
6 itest-fabricx-atsa - 40875981859.6 479
31.69
GitHub Action Run
7 itest-fabricx-simple - 40875981859.7 479
29.04
GitHub Action Run
8 utest-postgres - 40875981859.8 182
27.7
GitHub Action Run
9 itest-fabricx-multiendorsement - 40875981859.9 479
29.51
GitHub Action Run
10 itest-fabric-faultrecovery-postgres-outage - 40875981859.10 447
39.57
GitHub Action Run
11 itest-fabricx-configupdate - 40875981859.11 479
29.58
GitHub Action Run
12 itest-fabric-atsa - 40875981859.12 447
45.19
GitHub Action Run
13 itest-fabric-configupdate - 40875981859.13 457
39.51
GitHub Action Run
14 itest-fabric-runtimeconfig - 40875981859.14 457
39.82
GitHub Action Run
15 itest-fabric-iou - 40875981859.15 457
41.86
GitHub Action Run
16 itest-fsc-signedpingpong - 40875981859.16 247
30.76
GitHub Action Run
17 utest-root - 40875981859.17 485
89.99
GitHub Action Run
18 itest-fabric-faultrecovery - 40875981859.18 447
40.76
GitHub Action Run
19 itest-fabric-atsachaincode - 40875981859.19 452
31.55
GitHub Action Run
20 itest-fabricx-deployment - 40875981859.20 479
29.52
GitHub Action Run
21 itest-fabric-iouhsm - 40875981859.21 457
38.93
GitHub Action Run
22 itest-fabric-faultrecovery-replication - 40875981859.22 447
39.37
GitHub Action Run
23 itest-fabricx-faultrecovery - 40875981859.23 479
29.59
GitHub Action Run
24 itest-fabric-twonets - 40875981859.24 447
37.7
GitHub Action Run
25 itest-fsc-stoprestart - 40875981859.25 248
34.12
GitHub Action Run
Source Files on build 40875981859