hyperledger-labs / fabric-smart-client / 40857904301
91%

DEFAULT BRANCH: main
Ran
Jobs 26
Files 494
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 91.459% (-0.02%) from 91.475%
40857904301

push

github

web-flow 
test: move the root module's gomega unit tests to testify and run them in parallel (#2375)

The unit tests in the view and fabric SQL stores, the keyset pagination,
the vault store, the gRPC stats handler, channelconfig and two MSP files
assert with testify's require. Eight of these files called
gomega.RegisterTestingT, which sets a process-wide default: with
t.Parallel() the race detector reports gomega's ConfigureWithT racing
across tests. They now run in parallel, together with every test in
platform/fabric/services/db/driver/sql/common.

TestPaginationStoreMem and TestVaultStoreMem open their memory vaults
under different names. The memory driver keeps one SQLite database per
process, and with the same name the two parallel tests shared tables.

The subtests in application_test.go and the two MSP files asserted
through the parent test's gomega. Each subtest asserts on its own t, so
the MSP subtests run in parallel as well. TestVaultSQL_QueryStatus builds
its pagination values in the parent before any subtest starts.

The iterator tests in unversioned_test.go read with
iterators.ReadAllValues and compare keys as well as values; the loop they
used stopped at a nil value without checking the error returned with it.

The test list of every touched package is unchanged, and each package
passes go test -race -count=3 -shuffle=on five times in a row.
Ginkgo suites are left to #2363; the integration module keeps gomega.

Closes #2362

Signed-off-by: Marcus Brandenburger <bur@zurich.ibm.com>

30081 of 32890 relevant lines covered (91.46%)

1266.08 hits per line

Coverage Regressions

Lines Coverage ∆ File
2
96.66
-0.61% platform/fabric/core/generic/delivery/delivery.go
2
87.67
-2.74% platform/fabric/core/generic/msp/idemix/cache.go
2
91.95
-1.34% platform/view/services/metrics/prometheus/provider.go
2
76.69
-0.61% platform/fabric/core/generic/msp/idemix/provider.go
1
93.18
-0.57% platform/fabric/core/generic/ordering/bft.go
Jobs
ID Job ID Ran Files Coverage
1 itest-fsc-signedpingpong - 40857904301.1 247
30.76
GitHub Action Run
2 utest-postgres - 40857904301.2 182
27.7
GitHub Action Run
3 itest-fabricx-simple - 40857904301.3 479
28.99
GitHub Action Run
4 itest-fabricx-deployment - 40857904301.4 479
29.51
GitHub Action Run
5 utest-extensions - 40857904301.5 8
52.69
GitHub Action Run
6 itest-fabric-iou-libp2p - 40857904301.6 457
37.12
GitHub Action Run
7 itest-fabric-events - 40857904301.7 452
29.67
GitHub Action Run
8 itest-fabric-configupdate - 40857904301.8 457
39.45
GitHub Action Run
9 itest-fabric-stoprestart - 40857904301.9 447
32.25
GitHub Action Run
10 itest-fabric-iouhsm - 40857904301.10 457
40.71
GitHub Action Run
11 itest-fabric-faultrecovery - 40857904301.11 447
40.72
GitHub Action Run
12 itest-fabricx-faultrecovery - 40857904301.12 479
29.28
GitHub Action Run
13 itest-fabric-faultrecovery-replication - 40857904301.13 447
39.23
GitHub Action Run
14 itest-fabric-atsa - 40857904301.14 447
44.72
GitHub Action Run
15 itest-fabric-runtimeconfig - 40857904301.15 457
39.83
GitHub Action Run
16 itest-fabric-atsachaincode - 40857904301.16 452
31.55
GitHub Action Run
17 itest-fabric-twonets - 40857904301.17 447
37.71
GitHub Action Run
18 itest-fsc-stoprestart - 40857904301.18 248
34.46
GitHub Action Run
19 itest-fabric-iou - 40857904301.19 457
41.67
GitHub Action Run
20 utest-root - 40857904301.20 485
89.99
GitHub Action Run
21 itest-fabric-faultrecovery-postgres-outage - 40857904301.21 447
39.75
GitHub Action Run
22 itest-fabricx-iou - 40857904301.22 479
30.33
GitHub Action Run
23 itest-fabricx-multiendorsement - 40857904301.23 479
29.56
GitHub Action Run
24 itest-fabricx-configupdate - 40857904301.24 479
29.62
GitHub Action Run
25 itest-fabricx-atsa - 40857904301.25 479
31.73
GitHub Action Run
26 itest-fsc-pingpong - 40857904301.26 252
35.47
GitHub Action Run
Source Files on build 40857904301