hyperledger-labs / fabric-smart-client / 40844247637
91%

DEFAULT BRANCH: main
Ran
Jobs 0
Files 0
Run time –
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
40844247637

push

github

web-flow 
ci(codeql): extract each unit-tested module once, with its tests (#2371)

The CodeQL tracer runs `go-extractor --mimic go <args>` before every
traced go build, install, run or test, and the extractor hands the flags
before the first package pattern to go list. In the "Build manually"
step, `go test -run '^$' -count=1 ./...` passed `-run`, which go list
rejects ("flag provided but not defined: -run"), and
`go test -C integration ...` passed `-C`. Both extractions failed while
the go test commands succeeded, so the step stayed green, the database
held no _test.go file, and integration/nwo came in only through
`make install-fsccli`.

The extractor includes _test.go files only when it mimics go test; for
go build it ignores CODEQL_EXTRACTOR_GO_OPTION_EXTRACT_TESTS. The step
now runs `go test -n` once per module that `make unit-tests` covers: the
root module, ./nwo/... and ./fabric/common/... in integration, and the
libp2p host module. -n is a build flag go list accepts, and go test then
prints its build commands instead of compiling and linking test
binaries. Its output is several MB, so the step discards it and, on
failure, runs `go list -test` to print the package loading error.

Running the pinned extractor (bundle v2.26.3) the way the tracer does
archives 1218 FSC files, 480 of them _test.go, for the root module,
against 738 and 0 for `go build ./...`. The integration packages give
200 files (47 tests, 186 under nwo) and the libp2p module 12 (3 tests).
In CI the database holds 1448 FSC files, 530 of them _test.go, and the
step takes 91 s instead of 215 to 225 s. The job takes 3m36s instead of
5m35s to 6m8s. Code scanning reports no new alerts; the six results in
test code were already dismissed on main.

ci/codeql/node existed only for this step, and ./... extracts the node
package it wraps, so delete it.

The job does not restore the itest Go build cache: go test -n compiles
nothing, and setup-go already caches the modules go list needs.

Closes #236... (continued)
Source Files on build 40844247637
Detailed source file information is not available for this build.