IJHack / QtPass / 40801571096

93%

push

github

Git: keep to the store when its parent's path holds the list separator (#2086)

* Git: keep to the store when its parent's path holds the list separator (#2076)

With "use a parent repository" off, QtPass fences git in with
GIT_CEILING_DIRECTORIES set to the store's parent. git splits that list
on ":" (";" on Windows), so a parent such as /home/me/a:b became two
entries, neither of them the parent, and git climbed to a repository
above the store (a dotfiles one in the home folder) and added, committed
and pushed there.

Util::gitStoreVariables() returns the ceiling and, when the ceiling holds
the separator, GIT_DIR and GIT_WORK_TREE naming the store's own .git and
the store: git then uses the store's repository, or finds none, never
the one above. Pass::updateEnv() and ProfileInit use it; pass unsets
GIT_DIR for itself and keeps its own ceiling.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01VJygpMUf461yZgfAqwMJ6d
Signed-off-by: Anne Jan Brouwer <brouwer@annejan.com>

* Git ceiling: say what it covers, and the pass backend's limit

Henk's review of #2086: pass sets GIT_CEILING_DIRECTORIES to its store's
parent itself and unsets GIT_DIR, so with the pass backend a parent path
holding ":" still lets pass's own Git steps climb. QtPass cannot change
that in pass; the CHANGELOG entry now says the fix is for native Git
mode, and SECURITY.md states both what QtPass keeps Git to and the pass
backend's limit.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01VJygpMUf461yZgfAqwMJ6d
Signed-off-by: Anne Jan Brouwer <brouwer@annejan.com>

* Git ceiling: pin only a store the user owns; test ";" on Windows

CodeRabbit on #2086:

- An explicit GIT_DIR skips Git's ownership check (safe.directory), which
  runs only while Git discovers a repository. Pinning another user's
  store would have had Git use that repository, and run its hooks, as
  this user. On... (continued)

29 of 38 new or added lines in 3 files covered. (76.32%)

9692 of 10478 relevant lines covered (92.5%)

337.77 hits per line