petl-developers / petl / 40723719568

94%

push

github

Close XLSX workbooks when iteration exits early (#766)

Close XLSX workbooks in `finally` using openpyxl's public `Workbook.close()` API.

The existing cleanup runs only after the row loop has been exhausted. If
a consumer closes the generator early, throws an exception into it, or
selects a missing worksheet, the read-only workbook's ZIP archive
remains open. This is a newly reproduced resource-management defect,
rather than a duplicate of an existing issue.

Co-authored-by: nawaaaaaAaar <198336470+nawaaaaaAaar@users.noreply.github.com>

43 of 44 new or added lines in 2 files covered. (97.73%)

16257 of 17417 relevant lines covered (93.34%)

0.93 hits per line