petl-developers / petl

92%

LAST BUILD ON BRANCH master

branch: SELECT

CHANGE BRANCH

x

• No branch selected
• 1
• 666-drop-table-if-exists
• align-docs-changes-with-github
• chore/reduce-linting
• ci/fix-python-version-build
• ci/fix-readthedocs
• ci/fix-readthedocs-v2
• dependabot/pip/lxml-4.6.5
• doc/release1.7.16
• feature/normalize-timestamps
• feature/standardize-data
• fix-filldown-header-only
• fix-fromdicts-dicts-method-shadow
• fix-header-method-shadow
• fix-tojson-stdin-double-read
• fix/ci-codacy
• fix/ci-codacy-again
• fix/ci-codacy-yaml
• fix/ci-improve-scan-tests
• fix/ci-macos
• fix/ci-petl-setup
• fix/util.base.expr
• issue-627-parquet-output
• json-inference-issue-644
• master
• patch-1
• uneven_row_joins
• v1.3.0
• v1.3.0rc2
• v1.3.0rc3
• v1.4.0
• v1.5.0
• v1.6.0
• v1.6.1
• v1.6.2
• v1.6.3
• v1.6.4
• v1.6.5
• v1.6.6
• v1.6.7
• v1.6.8
• v1.7.0
• v1.7.1
• v1.7.10
• v1.7.11
• v1.7.12
• v1.7.13
• v1.7.14
• v1.7.15
• v1.7.2
• v1.7.3
• v1.7.4
• v1.7.5
• v1.7.6
• v1.7.7
• v1.7.8
• v1.7.9

Build # 30491666045

Build Type

push

github

Committed by web-flow

Commit Message

Fix header instance attribute shadowing Table.header() across views (#704)

Fix header instance attr shadowing Table.header() method across views

Table binds header() as a class method, but many Table subclasses store
their header argument as self.header, silently replacing the method with
data. Calling the fluent .header() then raises TypeError, e.g.
fromcsv(p).header() -> 'NoneType' object is not callable.

Rename the stored attribute to self._header in every affected view, the
same fix #555 applied to fromdicts (renamed header -> _header, released
in 1.7.5 as a bugfix). Covers fromcsv, fromtext, fromjson, fromcolumns,
cat, pushheader, setheader, rowmap, rowmapmany, rowgroupmap, rowreduce,
mergesort and validate; #555 missed the fromjson sibling.

Coverage Stats

106 of 109 new or added lines in 12 files covered. (97.25%)

13845 of 15101 relevant lines covered (91.68%)

0.92 hits per line