grpc / grpc-java / #20544
89%

DEFAULT BRANCH: master
Ran
Jobs 1
Files 696
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 89.45% (+0.02%) from 89.435%
#20544

push

github

web-flow 
xds: Reject duplicate endpoint addresses in EDS (#13127)

Fixes #13119.

Reject duplicate endpoint socket addresses while parsing EDS resources.
  Previously, these resources were ACKed and could trigger a panic in
  outlier detection.

Track addresses across the original locality entries, including entries
  that may later be overwritten in the locality-keyed output map. Reject
duplicates via ResourceInvalidException so the existing NACK path
retains
  the last accepted resource and version.

  Validation includes additional addresses when dual-stack is enabled.
  The same IP with different ports remains valid, and zero-weight
  localities remain ignored.

  Regression tests cover duplicates within and across localities and
  priorities, overwritten locality entries, equivalent IPv6 addresses,
  dual-stack addresses, cold start, repeated NACKs, and recovery.

  ### Testing

  - Original parser: 14 of 18 new parameterized regression cases fail.
  - Patched parser: all 272 cases in GrpcXdsClientImplV3Test pass using
    a standalone JUnit harness with grpc-java 1.85.0 dependencies.
  - Checkstyle 10.26.1 passes for both modified files.

  ### Gradle build success

```
[16:17:13] /Users/valter/projects/grpc-java-pr git:(fix-13119-duplicate-eds-endpoints) > ./gradlew -PskipCodegen=true -PskipAndroid=true \
    :grpc-xds:test --tests io.grpc.xds.GrpcXdsClientImplV3Test \
    :grpc-xds:checkstyleMain :grpc-xds:checkstyleTest

Welcome to Gradle 8.14.5!

Here are the highlights of this release:
 - Java 24 support
 - GraalVM Native Image toolchain selection
 - Enhancements to test reporting
 - Build Authoring improvements

For more details see https://docs.gradle.org/8.14.5/release-notes.html

Starting a Gradle Daemon (subsequent builds will be faster)
*** Skipping the build of codegen and compilation of proto files because skipCodegen=true
  * Skipping the build of Android projects because skipAndroid=true

> Task :grpc-services:compileJava
Note: Some input ... (continued)

39409 of 44057 relevant lines covered (89.45%)

0.89 hits per line

Coverage Regressions

Lines Coverage ∆ File
18
82.64
0.89% ../xds/src/main/java/io/grpc/xds/XdsEndpointResource.java
3
95.1
-0.43% ../core/src/main/java/io/grpc/internal/RetriableStream.java
2
81.05
0.0% ../okhttp/src/main/java/io/grpc/okhttp/ExceptionHandlingFrameWriter.java
1
87.6
-0.83% ../rls/src/main/java/io/grpc/rls/LinkedHashLruCache.java
Jobs
ID Job ID Ran Files Coverage
1 #20544.1 696
89.45
Source Files on build #20544