#20543
89%

Ran 26 Oct 2026 12:41PM UTC

Jobs 1

Files 696

Run time 1min

Badge

Embed ▾

Committed 26 Oct 2026 12:31PM UTC coverage: 89.435% (-0.02%) from 89.451%

Build # #20543

Build Type

push

github

Committed by

web-flow

Commit Message

core: Reject retryThrottling without maxTokens or tokenRatio clearly (#13131)

## Problem

`ServiceConfigUtil.getThrottlePolicy()` reads the two required fields of
`retryThrottling` with `JsonUtil.getNumberAsDouble(...).floatValue()`.
When
either field is missing, `getNumberAsDouble` returns null and the call
fails
with an NPE:

Cannot invoke "java.lang.Double.floatValue()" because the return value
of
"io.grpc.internal.JsonUtil.getNumberAsDouble(java.util.Map, String)" is
null

`ScParser` catches it and the channel reports `UNKNOWN: failed to parse
service config`, but the cause doesn't say which field is missing. This
was
noted in the code as `TODO(dapengzhang0): check if this is null.`

## Fix

Check both fields with `checkNotNull(..., "<field> cannot be empty")`,
the
same message used for the required `retryPolicy` and `hedgingPolicy`
fields
in `ManagedChannelServiceConfig`. The exception type is still the NPE
that
`ScParser` already handles, so the only change is a clearer message.

## Testing

Added `getThrottlePolicy_failOnMissingMaxTokens` and
`getThrottlePolicy_failOnMissingTokenRatio` to `ServiceConfigUtilTest`.
Both
failed before the fix with the NPE above.

Coverage Stats

39396 of 44050 relevant lines covered (89.43%)

0.89 hits per line

Coverage Regressions

Lines	Coverage	∆	File
18	82.64	0.5%	../core/src/main/java/io/grpc/internal/ServiceConfigUtil.java
7	96.0	0.1%	../core/src/main/java/io/grpc/internal/ServerCallImpl.java
4	73.27	-3.96%	../servlet/src/main/java/io/grpc/servlet/AsyncServletOutputStreamWriter.java
4	91.59	-1.87%	../xds/src/main/java/io/grpc/xds/client/ControlPlaneClient.java
2	81.05	-2.11%	../okhttp/src/main/java/io/grpc/okhttp/ExceptionHandlingFrameWriter.java
1	90.28	-0.35%	../core/src/main/java/io/grpc/internal/DelayedClientCall.java
1	74.14	-0.86%	../servlet/src/main/java/io/grpc/servlet/ServletServerStream.java

Jobs

ID	Job ID	Ran	Files	Coverage
1	#20543.1	26 Oct 2026 12:41PM UTC	696	89.43

grpc / grpc-java / #20543
89%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Coverage Regressions

Jobs

Source Files on build #20543

grpc / grpc-java / #20543 89%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Coverage Regressions

Jobs

Source Files on build #20543

grpc / grpc-java / #20543
89%

README BADGES
x