PeculiarVentures / xmldsigjs / 40571123039

86%

push

github

refactor(deps): replace pvtsutils with @peculiar/utils (#148)

xmldsigjs used pvtsutils only in SignedXml: BufferSourceConverter
(isBufferSource, toArrayBuffer, toUint8Array) and Convert (UTF-8 and
Base64). They become isBufferSource, toArrayBuffer, utf8.decode,
base64.decode and base64.encode from @peculiar/utils ^4.1.0, root entry
only (no `/legacy`). pvutils was declared but never imported; both are
dropped, and neither is left in the dependency tree.

One behavior change: XML passed to SignedXml as bytes is decoded with
TextDecoder, so invalid UTF-8 becomes U+FFFD instead of throwing
URIError. New specs cover a Uint8Array view with an offset, UTF-8 bytes
with a BOM, invalid UTF-8 and a non-Base64 `x509` option (still a
TypeError).

@peculiar/utils types its decoders as Uint8Array<ArrayBufferLike>, so
the specs cast before handing them to WebCrypto.

1120 of 1511 branches covered (74.12%)

8 of 8 new or added lines in 1 file covered. (100.0%)

2271 of 2648 relevant lines covered (85.76%)

2350.44 hits per line