PeculiarVentures / xmldsigjs / 40571742619

86%

Build Type

push

github

Committed by web-flow

Commit Message

fix(core)!: reimplement Convert on @peculiar/utils (#149)

xml-core's Convert built strings with String.fromCharCode.apply and
decoded UTF-8 with the deprecated escape/unescape, so
Convert.ToUtf8String threw "RangeError: Maximum call stack size
exceeded" for inputs from about 125 KB, and Convert.ToString read a
DataView as an empty buffer. Its static methods now delegate to
@peculiar/utils ^4.1.0 (utf8, base64, base64url, hex, binary,
toUint8Array), the same helpers xmldsigjs uses. The public API is
unchanged; Base64 still ignores whitespace and accepts missing padding.

Specs cover large input, invalid UTF-8, DataView offsets, Base64 and
Base64Url padding and garbage, and hex separators.

BREAKING CHANGE: xml-core's Convert decodes more strictly. FromBase64/FromBase64Url throw TypeError (was a DOMException InvalidCharacterError) for text that isn't Base64; FromHex throws TypeError for odd-length text or non-hex characters (was silently wrong bytes) and ignores the separators space, tab, newline, ":", "-" and "."; ToUtf8String/FromUtf8String replace invalid UTF-8 and lone surrogates with U+FFFD instead of throwing URIError. xml-core now depends on @peculiar/utils.

Coverage Stats

1114 of 1501 branches covered (74.22%)

12 of 12 new or added lines in 1 file covered. (100.0%)

5 existing lines in 1 file now uncovered.

2241 of 2617 relevant lines covered (85.63%)

2062.35 hits per line