PeculiarVentures / xmldsigjs / 40569344138

86%

push

github

build(deps)!: move pkijs, asn1js and internal packages to peer dependencies (#147)

Follow 04-dependency-strategy: packages that hold module-level state or
are checked with `instanceof`, and whose objects cross the public API,
become peer dependencies (and dev dependencies, for the tests), so an
app gets one copy and a conflicting major fails at install instead of at
runtime.

- xmldsigjs: pkijs ^4.0.0 (Application.setEngine installs the pkijs
  engine; X509Certificate holds a pkijs Certificate in its protected
  `simpl`), asn1js ^4.0.0 (X509Certificate parses with asn1js and hands
  the result to pkijs, which checks it with instanceof) and xml-core (setNodeDependencies registry and the
  decorator schemas must be the app's copy).
- xadesjs: xml-core and xmldsigjs (Application engine, algorithm and
  transform registries).
- xmldsigjs no longer lists xpath: its source never imports it. xpath and
  @xmldom/xmldom stay peers of xml-core, which receives them through
  setNodeDependencies; xpath now accepts 0.0.35 too.

The internal ranges (^1.2.6, ^2.8.8) become ^3.0.0 in the release PR.
Tests run with @peculiar/webcrypto 2. The pkijs 3 typings cast in
Application.setEngine is gone.

BREAKING CHANGE: pkijs ^4.0.0 and asn1js ^4.0.0 are peer dependencies of xmldsigjs, and xml-core and xmldsigjs are peer dependencies of xadesjs. npm 7+ installs them automatically; an app that pins pkijs 3 or asn1js 3 must upgrade. xmldsigjs no longer depends on xpath directly; it comes with xml-core's peers.

1119 of 1511 branches covered (74.06%)

1 of 1 new or added line in 1 file covered. (100.0%)

2270 of 2648 relevant lines covered (85.73%)

2344.42 hits per line