PeculiarVentures / xmldsigjs / 40568683356

86%

push

github

build!: ship ESM-only output for Node.js ^20.19.0 || >=22.12.0 (#146)

One root tsdown.config.ts (asn1-schema's) builds xml-core, xmldsigjs
and xadesjs in workspace mode: ESM only, platform neutral, unbundled
build/*.js and build/*.d.ts, attw with the esm-only profile. It replaces
the dual esm+cjs build from #132 and its `module`/`default` exports
mapping. `exports`, `main`, `module` and `types` are generated.

Every package gets `"type": "module"`, engines `^20.19.0 || >=22.12.0`
(was >=16), `files: ["build/", "README.md", "LICENSE"]` and a
`repository.directory`.

tsconfig.json is pvtsutils's plus the allowed deviations
`experimentalDecorators`, `useDefineForClassFields: false` (without it
the build emits class fields that shadow the accessors installed by the
xml-core decorators) and `lib: ["es2023", "DOM"]` (Node, Document,
CryptoKey; until now DOM only came in through xpath's typings), with
`paths` to the sibling sources and `types: ["node"]` for the specs. The
paths also fix the declaration build: #132 resolved xml-core through its
own build/, which the parallel workspace build cleans, so some xmldsigjs
and xadesjs types came out as `any`.
tsconfig.compile.json, tsdown.config.mts and vitest.config.mts are
replaced by tsdown.config.ts and vitest.config.ts.

TypeScript 6's DOM lib only accepts ArrayBuffer-backed views as
BufferSource: xml-core's Convert.From* now return Uint8Array<ArrayBuffer>
(they always allocated a new ArrayBuffer), and WebCrypto call sites cast
their Uint8Array inputs. pkijs 3's CryptoEngine typings don't match that
lib either; the cast goes away with pkijs 4.

Dev dependencies move to their latest versions: TypeScript 6,
@types/node 26, tsdown 0.23.2, vitest 5.0.5, oxlint 1.90, oxfmt 0.75. The
vite override is no longer needed.

BREAKING CHANGE: xml-core, xmldsigjs and xadesjs are ESM-only and require Node.js ^20.19.0 || >=22.12.0 (was >=16). CommonJS code can still require() them on those versions; Node.js 22.0-22.11 cannot.... (continued)

1119 of 1511 branches covered (74.06%)

5 of 5 new or added lines in 5 files covered. (100.0%)

2270 of 2648 relevant lines covered (85.73%)

2344.42 hits per line